Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: push necessary predicates without virtual column down through UnionScan (#54985) | tidb-test=release-6.5 plugin=release-6.5 #55152

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 2, 2024

This is an automated cherry-pick of #54985

What problem does this PR solve?

Issue Number: close #54870

Problem Summary: planner: push necessary predicates without virtual column down through UnionScan

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
Copy link

tiprow bot commented Aug 2, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 03:24:56.453404801 +0000 UTC m=+59893.672166391: ☑️ agreed by hawkingrei.
  • 2024-08-02 03:37:48.892465609 +0000 UTC m=+60666.111227217: ☑️ agreed by time-and-fate.

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5-20240801-v6.5.10@ff2feb6). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             release-6.5-20240801-v6.5.10     #55152   +/-   ##
=================================================================
  Coverage                                ?   73.7895%           
=================================================================
  Files                                   ?       1096           
  Lines                                   ?     353065           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     260525           
  Misses                                  ?      75891           
  Partials                                ?      16649           

@qw4990 qw4990 changed the title planner: push necessary predicates without virtual column down through UnionScan (#54985) planner: push necessary predicates without virtual column down through UnionScan (#54985) | tidb-test=release-6.5 plugin=release-6.5 Aug 2, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 1d0e586 into pingcap:release-6.5-20240801-v6.5.10 Aug 2, 2024
9 of 10 checks passed
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants