statistics: move history-related functions into the stats handle #55163

Rustin170506 · 2024-08-02T08:50:33Z

What problem does this PR solve?

Problem Summary:

In the above issue comment, we decided to remove the dedicated analyze sessions. But after we removed them we need to find a better way to write the analysis job history. Theoretically we can call _, _, err := exec.ExecRestrictedSQL(ctx, []sqlexec.OptionFuncAlias{sqlexec.ExecOptionUseSessionPool}, sql, args...) concurrently to do it. But it is counterintuitive because we need to use the same session to get the executor and then use it to exec SQL with the session pool.

Because we already moved InsertAnalyzeJob into the stats handle, so I decided to move other job history-related functions into it as well.

What changed and how does it work?

Moved startAnalyzeJob into the stats handle.
Moved UpdateAnalyzeJob into the stats handle.
Moved FinishAnalyzeMergeJob and FinishAnalyzeJob into the stats handle. Reused the common code to reduce code duplication.

For the single thread code, I decided to pass the stats handle to it. For workers, every worker will load it by themself.

Check List

Tests

Unit test
Integration test
Manual test 1. statistics: move history-related functions into the stats handle #55163 (comment) 2.statistics: move history-related functions into the stats handle #55163 (comment)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

codecov · 2024-08-02T09:14:34Z

Codecov Report

Attention: Patch coverage is 66.90647% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.8445%. Comparing base (801d5d6) to head (2552ffe).
Report is 39 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55163        +/-   ##
================================================
+ Coverage   72.8365%   74.8445%   +2.0079%     
================================================
  Files          1564       1569         +5     
  Lines        439076     447605      +8529     
================================================
+ Hits         319808     335008     +15200     
+ Misses        99580      92011      -7569     
- Partials      19688      20586       +898

Flag	Coverage Δ
integration	`49.4738% <49.6402%> (?)`
unit	`71.7824% <66.9064%> (-0.0515%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`51.8199% <ø> (+5.9399%)`	⬆️

Rustin170506 · 2024-08-05T06:07:31Z

Failpoint test:

[2024/08/05 13:57:31.784 +08:00] [INFO] [autoanalyze.go:725] [InsertAnalyzeJob] [table_schema=test] [table_name=t] [partition_name=] [job_info="analyze table index ia, column a with 256 buckets, 3 topn, 1 samplerate"] [job_id=1]
[2024/08/05 13:57:31.816 +08:00] [INFO] [autoanalyze.go:838] [FinishAnalyzeJob] [end_time=2024/08/05 13:57:31.816 +08:00] ["job id"=7] ["increase processed_rows"=27]

Rustin170506 · 2024-08-05T06:38:09Z

Tested locally:

Start the TiDB cluster: tiup playground nightly --db.binpath /Volumes/t7/code/tidb/bin/tidb-server
Create a partitioned table and insert 2000 rows to each partition:

#!/usr/bin/env -S cargo +nightly -Zscript
---cargo
[dependencies]
clap = { version = "4.2", features = ["derive"] }
sqlx = { version = "0.7", features = ["runtime-tokio-rustls", "mysql"] }
tokio = { version = "1", features = ["full"] }
fake = { version = "2.5", features = ["derive"] }
---

use clap::Parser;
use fake::{Fake, Faker};
use sqlx::mysql::MySqlPoolOptions;

#[derive(Parser, Debug)]
#[clap(version)]
struct Args {
    #[clap(short, long, help = "MySQL connection string")]
    database_url: String,
}

#[derive(Debug)]
struct TableRow {
    partition_key: u32,
    column1: String,
    column2: i32,
    column3: i32,
    column4: String,
}

#[tokio::main]
async fn main() -> Result<(), sqlx::Error> {
    let args = Args::parse();

    let pool = MySqlPoolOptions::new()
        .max_connections(5)
        .connect(&args.database_url)
        .await?;

    // Create partitioned table if not exists
    sqlx::query(
        "CREATE TABLE IF NOT EXISTS t (
            partition_key INT NOT NULL,
            column1 VARCHAR(255) NOT NULL,
            column2 INT NOT NULL,
            column3 INT NOT NULL,
            column4 VARCHAR(255) NOT NULL
        ) PARTITION BY RANGE (partition_key) (
            PARTITION p0 VALUES LESS THAN (3000),
            PARTITION p1 VALUES LESS THAN (6000),
            PARTITION p2 VALUES LESS THAN (9000),
            PARTITION p3 VALUES LESS THAN (12000),
            PARTITION p4 VALUES LESS THAN (15000),
            PARTITION p5 VALUES LESS THAN (18000),
            PARTITION p6 VALUES LESS THAN (21000),
            PARTITION p7 VALUES LESS THAN (24000),
            PARTITION p8 VALUES LESS THAN (27000),
            PARTITION p9 VALUES LESS THAN (30000),
            PARTITION p10 VALUES LESS THAN (33000),
            PARTITION p11 VALUES LESS THAN (36000),
            PARTITION p12 VALUES LESS THAN (39000),
            PARTITION p13 VALUES LESS THAN (42000),
            PARTITION p14 VALUES LESS THAN (45000),
            PARTITION p15 VALUES LESS THAN (48000),
            PARTITION p16 VALUES LESS THAN (51000),
            PARTITION p17 VALUES LESS THAN (54000),
            PARTITION p18 VALUES LESS THAN (57000),
            PARTITION p19 VALUES LESS THAN (60000),
            PARTITION p20 VALUES LESS THAN (63000)
        )"
    )
    .execute(&pool)
    .await?;

    // Insert 3000 rows into each of the 20 partitions
    for partition in 1..=20 {
        let partition_key = partition * 3000 + 1; // This ensures each partition key is unique

        for _ in 0..3000 {
            let row = TableRow {
                partition_key, // Use the current partition key
                column1: Faker.fake::<String>(),
                column2: Faker.fake::<i32>(),
                column3: Faker.fake::<i32>(),
                column4: Faker.fake::<String>(),
            };

            sqlx::query(
                "INSERT INTO t (partition_key, column1, column2, column3, column4) 
                VALUES (?, ?, ?, ?, ?)"
            )
            .bind(row.partition_key)
            .bind(&row.column1)
            .bind(row.column2)
            .bind(row.column3)
            .bind(&row.column4)
            .execute(&pool)
            .await?;
        }

        println!("Successfully inserted 3000 rows into partition {} of the 't' table.", partition);
    }

    Ok(())
}

chmod +x ./sql4.rs && ./sql4.rs '--database-url=mysql://root@localhost:4000/test'
warning: `package.edition` is unspecified, defaulting to `2021`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s
     Running `/Users/hi-rustin/.cargo/target/5c/99de6319c9436c/debug/sql4 '--database-url=mysql://root@localhost:4000/test'`
Successfully inserted 3000 rows into partition 1 of the 't' table.
Successfully inserted 3000 rows into partition 2 of the 't' table.
Successfully inserted 3000 rows into partition 3 of the 't' table.
Successfully inserted 3000 rows into partition 4 of the 't' table.
Successfully inserted 3000 rows into partition 5 of the 't' table.
Successfully inserted 3000 rows into partition 6 of the 't' table.
Successfully inserted 3000 rows into partition 7 of the 't' table.
Successfully inserted 3000 rows into partition 8 of the 't' table.
Successfully inserted 3000 rows into partition 9 of the 't' table.
Successfully inserted 3000 rows into partition 10 of the 't' table.
Successfully inserted 3000 rows into partition 11 of the 't' table.
Successfully inserted 3000 rows into partition 12 of the 't' table.
Successfully inserted 3000 rows into partition 13 of the 't' table.
Successfully inserted 3000 rows into partition 14 of the 't' table.
Successfully inserted 3000 rows into partition 15 of the 't' table.
Successfully inserted 3000 rows into partition 16 of the 't' table.
Successfully inserted 3000 rows into partition 17 of the 't' table.
Successfully inserted 3000 rows into partition 18 of the 't' table.
Successfully inserted 3000 rows into partition 19 of the 't' table.
Successfully inserted 3000 rows into partition 20 of the 't' table.

Check logs and job history:

[2024/08/05 14:32:28.124 +08:00] [INFO] [refresher.go:102] ["Auto analyze triggered"] [category=stats] [job="DynamicPartitionedTableAnalysisJob:\n\tAnalyzeType: analyzeDynamicPartition\n\tPartitions: p10, p11, p13, p16, p5, p3, p15, p19, p20, p1, p8, p14, p7, p4, p6, p9, p12, p17, p18, p2\n\tPartitionIndexes: map[]\n\tSchema: test\n\tGlobal Table: t\n\tGlobal TableID: 104\n\tTableStatsVer: 2\n\tChangePercentage: 1.000000\n\tTableSize: 15000.00\n\tLastAnalysisDuration: 30m0s\n\tWeight: 1.376307\n"]

mysql> select * from mysql.analyze_jobs;
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
| id | update_time         | table_schema | table_name | partition_name | job_info                                                    | processed_rows | start_time          | end_time            | state    | fail_reason | instance       | process_id |
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
|  1 | 2024-08-05 14:32:28 | test         | t          | p10            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  2 | 2024-08-05 14:32:28 | test         | t          | p11            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  3 | 2024-08-05 14:32:28 | test         | t          | p13            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  4 | 2024-08-05 14:32:28 | test         | t          | p16            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  5 | 2024-08-05 14:32:28 | test         | t          | p5             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  6 | 2024-08-05 14:32:28 | test         | t          | p3             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  7 | 2024-08-05 14:32:28 | test         | t          | p15            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  8 | 2024-08-05 14:32:28 | test         | t          | p19            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  9 | 2024-08-05 14:32:28 | test         | t          | p20            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 10 | 2024-08-05 14:32:28 | test         | t          | p1             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 11 | 2024-08-05 14:32:28 | test         | t          | p8             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 12 | 2024-08-05 14:32:28 | test         | t          | p14            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 13 | 2024-08-05 14:32:28 | test         | t          | p7             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 14 | 2024-08-05 14:32:28 | test         | t          | p4             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 15 | 2024-08-05 14:32:28 | test         | t          | p6             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 16 | 2024-08-05 14:32:28 | test         | t          | p9             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 17 | 2024-08-05 14:32:28 | test         | t          | p12            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 18 | 2024-08-05 14:32:28 | test         | t          | p17            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 19 | 2024-08-05 14:32:28 | test         | t          | p18            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 20 | 2024-08-05 14:32:28 | test         | t          | p2             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 21 | 2024-08-05 14:32:28 | test         | t          |                | merge global stats for test.t columns                       |              0 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
21 rows in set (0.01 sec)

Set stats version to 1:

mysql> set global tidb_analyze_version = 1;
Query OK, 0 rows affected (0.02 sec)
mysql> select @@tidb_analyze_version;
+------------------------+
| @@tidb_analyze_version |
+------------------------+
| 1                      |
+------------------------+
1 row in set (0.00 sec)

Analyze manually:

mysql> analyze table t partition p0;
Query OK, 0 rows affected (0.30 sec)

mysql> select * from mysql.analyze_jobs;
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
| id | update_time         | table_schema | table_name | partition_name | job_info                                                    | processed_rows | start_time          | end_time            | state    | fail_reason | instance       | process_id |
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
|  1 | 2024-08-05 14:32:28 | test         | t          | p10            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  2 | 2024-08-05 14:32:28 | test         | t          | p11            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  3 | 2024-08-05 14:32:28 | test         | t          | p13            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  4 | 2024-08-05 14:32:28 | test         | t          | p16            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  5 | 2024-08-05 14:32:28 | test         | t          | p5             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  6 | 2024-08-05 14:32:28 | test         | t          | p3             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  7 | 2024-08-05 14:32:28 | test         | t          | p15            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  8 | 2024-08-05 14:32:28 | test         | t          | p19            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
|  9 | 2024-08-05 14:32:28 | test         | t          | p20            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 10 | 2024-08-05 14:32:28 | test         | t          | p1             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 11 | 2024-08-05 14:32:28 | test         | t          | p8             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 12 | 2024-08-05 14:32:28 | test         | t          | p14            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 13 | 2024-08-05 14:32:28 | test         | t          | p7             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 14 | 2024-08-05 14:32:28 | test         | t          | p4             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 15 | 2024-08-05 14:32:28 | test         | t          | p6             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 16 | 2024-08-05 14:32:28 | test         | t          | p9             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 17 | 2024-08-05 14:32:28 | test         | t          | p12            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 18 | 2024-08-05 14:32:28 | test         | t          | p17            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 19 | 2024-08-05 14:32:28 | test         | t          | p18            | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 20 | 2024-08-05 14:32:28 | test         | t          | p2             | auto analyze table with 256 buckets, 100 topn, 1 samplerate |           3000 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 21 | 2024-08-05 14:32:28 | test         | t          |                | merge global stats for test.t columns                       |              0 | 2024-08-05 14:32:28 | 2024-08-05 14:32:28 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 22 | 2024-08-05 14:37:04 | test         | t          | p0             | analyze columns                                             |              0 | 2024-08-05 14:37:04 | 2024-08-05 14:37:04 | finished | NULL        | 127.0.0.1:4000 |       NULL |
| 23 | 2024-08-05 14:37:05 | test         | t          |                | merge global stats for test.t columns                       |              0 | 2024-08-05 14:37:04 | 2024-08-05 14:37:05 | finished | NULL        | 127.0.0.1:4000 |       NULL |
+----+---------------------+--------------+------------+----------------+-------------------------------------------------------------+----------------+---------------------+---------------------+----------+-------------+----------------+------------+
23 rows in set (0.01 sec)

Rustin170506 · 2024-08-05T06:40:03Z

/retest

Rustin170506

🔢 Self-check (PR reviewed by myself and ready for feedback.)

elsa0520

LGTM

ti-chi-bot · 2024-08-07T07:31:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,elsa0520]
~~pkg/statistics/OWNERS~~ [AilinKid,elsa0520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-08-07T07:31:22Z

[LGTM Timeline notifier]

Timeline:

2024-08-06 05:46:07.674109724 +0000 UTC m=+330897.541208811: ☑️ agreed by elsa0520.
2024-08-07 07:31:21.697119 +0000 UTC m=+423611.564218087: ☑️ agreed by AilinKid.

…gcap#55163) ref pingcap#55043

statistics: move startAnalyzeJob into stats handle

44cdfc9

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024

Rustin170506 changed the title ~~statistics: move startAnalyzeJob into the stats handle~~ statistics: move history-related functions into the stats handle Aug 2, 2024

statistics: move UpdateAnalyzeJob into stats handle

cb56800

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024

statistics: move FinishAnalyzeJob into stats handle

7ea5f40

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2024

Rustin170506 changed the title ~~statistics: move history-related functions into the stats handle~~ WIP: statistics: move history-related functions into the stats handle Aug 2, 2024

Rustin170506 added 7 commits August 5, 2024 13:23

fix: make lint happy

f745239

chore: better comments

80051a7

chore: better comments

ec552c7

chore: better comments

294eb83

feat: logging errors

e92ae21

fix: refine failpoints

7520c90

docs: add comments back

25cb570

chore: rename

b483677

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024

Rustin170506 changed the title ~~WIP: statistics: move history-related functions into the stats handle~~ statistics: move history-related functions into the stats handle Aug 5, 2024

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024

docs: better comments

2552ffe

Rustin170506 commented Aug 5, 2024

View reviewed changes

Rustin170506 requested a review from time-and-fate August 5, 2024 06:47

Rustin170506 requested a review from elsa0520 August 5, 2024 06:47

elsa0520 approved these changes Aug 6, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2024

AilinKid approved these changes Aug 7, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024

ti-chi-bot bot merged commit 686f8bc into pingcap:master Aug 7, 2024
22 of 23 checks passed

Rustin170506 deleted the rustin-patch-analyze-jobs branch August 8, 2024 00:29

hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 8, 2024

statistics: move history-related functions into the stats handle (pin…

5e6c732

…gcap#55163) ref pingcap#55043

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

statistics: move history-related functions into the stats handle #55163

statistics: move history-related functions into the stats handle #55163

Rustin170506 commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading

Rustin170506 commented Aug 5, 2024

Rustin170506 commented Aug 5, 2024

Rustin170506 commented Aug 5, 2024

Rustin170506 left a comment

elsa0520 left a comment

ti-chi-bot bot commented Aug 7, 2024

ti-chi-bot bot commented Aug 7, 2024

statistics: move history-related functions into the stats handle #55163

statistics: move history-related functions into the stats handle #55163

Conversation

Rustin170506 commented Aug 2, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

codecov bot commented Aug 2, 2024 • edited Loading

Codecov Report

Rustin170506 commented Aug 5, 2024

Rustin170506 commented Aug 5, 2024

Rustin170506 commented Aug 5, 2024

Rustin170506 left a comment

Choose a reason for hiding this comment

elsa0520 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 7, 2024

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Rustin170506 commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading