-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: Add option SkipWriteUntouchedIndices
for Table.UpdateRecord
#55192
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55192 +/- ##
================================================
- Coverage 74.8010% 73.4029% -1.3982%
================================================
Files 1570 1570
Lines 364690 439898 +75208
================================================
+ Hits 272792 322898 +50106
- Misses 72131 97058 +24927
- Partials 19767 19942 +175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3e51f77
to
09746b1
Compare
What problem does this PR solve?
Issue Number: ref #54397
What changed and how does it work?
table.SkipWriteUntouchedIndices
is introduced as a new option forTable.UpdateRecord
. It is used to decouple the code ofUpdateRecord
and the executor logic. It makes the code more clear and easier to read.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.