Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: add new option DupKeyCheckMode for table mutations #55194

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #54397

What changed and how does it work?

A new option is introduced for table:

// DupKeyCheckMode indicates how to check the duplicated key when adding/updating a record/index.
type DupKeyCheckMode uint8

const (
	// DupKeyCheckDefault indicates using the default behavior.
	// Currently, this means to use the return value `ctx.LazyCheckKeyNotExists()`.
	// If the above method returns true, it will only check the duplicated key in the memory buffer,
	// otherwise, it will also check the duplicated key in the storage.
	// TODO: add `DupKeyCheckLazy` to indicate only checking the duplicated key in the memory buffer.
	// After `DupKeyCheckLazy` added, `DupKeyCheckDefault` will be renamed to `DupKeyCheckInPlace` to force check
	// the duplicated key in place.
	DupKeyCheckDefault DupKeyCheckMode = iota
	// DupKeyCheckSkip indicates skipping the duplicated key check.
	DupKeyCheckSkip
)

In this case, the AddRecord/UpdateRecord will follow the instructions from the options to ignore the dup key check. It can decouple the logic from the outside business.

This PR is only for Skip mode and left other scenes using LazyCheckKeyNotExists to determine the dup key mode to make it easy to review. After this PR merged, we'll try to remove LazyCheckKeyNotExists in another PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
Copy link

tiprow bot commented Aug 5, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5835%. Comparing base (9a2da2d) to head (600bb84).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55194        +/-   ##
================================================
+ Coverage   74.8264%   75.5835%   +0.7571%     
================================================
  Files          1568       1592        +24     
  Lines        364498     452372     +87874     
================================================
+ Hits         272741     341919     +69178     
- Misses        72017      89221     +17204     
- Partials      19740      21232      +1492     
Flag Coverage Δ
integration 52.9302% <69.4444%> (?)
unit 71.7712% <100.0000%> (-1.9420%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 62.6740% <ø> (+15.0035%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2024
Copy link

ti-chi-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2024
Copy link

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 06:14:18.228858154 +0000 UTC m=+332588.095957242: ☑️ agreed by lance6716.
  • 2024-08-06 06:16:17.456840545 +0000 UTC m=+332707.323939628: ☑️ agreed by tangenta.

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Aug 6, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Aug 6, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1985662 into pingcap:master Aug 6, 2024
23 checks passed
@lcwangchao lcwangchao deleted the dupkeycheckskip branch August 6, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants