Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: update comments for statistics related variables #55220

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Aug 6, 2024

What problem does this PR solve?

Issue Number: ref #55043

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 added the sig/planner SIG: Planner label Aug 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9882%. Comparing base (801d5d6) to head (872dc80).
Report is 36 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55220        +/-   ##
================================================
+ Coverage   72.8365%   74.9882%   +2.1516%     
================================================
  Files          1564       1572         +8     
  Lines        439076     454115     +15039     
================================================
+ Hits         319808     340533     +20725     
+ Misses        99580      92862      -6718     
- Partials      19688      20720      +1032     
Flag Coverage Δ
integration 49.3577% <ø> (?)
unit 71.7444% <ø> (-0.0894%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 51.7748% <ø> (+5.8948%) ⬆️

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2024
Copy link

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 07:54:52.888312081 +0000 UTC m=+338622.755411166: ☑️ agreed by hawkingrei.
  • 2024-08-06 08:58:32.702531783 +0000 UTC m=+342442.569630872: ☑️ agreed by AilinKid.

@Rustin170506
Copy link
Member Author

/retest

@easonn7
Copy link

easonn7 commented Aug 7, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit c981864 into pingcap:master Aug 7, 2024
23 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants