Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump client-go to adopt new batch policy #55383

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Aug 13, 2024

What problem does this PR solve?

Issue Number: close #55206

Problem Summary: it's an enhancement, ref #55206 .

What changed and how does it work?

Make batch policy configurable and improve batch efficiency for high throughput workloads.

Check List

Tests

  • Unit test (at client-go)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make batch policy configurable and improve batch efficiency for high throughput workloads.

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2024
Copy link

tiprow bot commented Aug 13, 2024

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-13 06:04:00.397971659 +0000 UTC m=+247925.101441304: ☑️ agreed by ekexium.
  • 2024-08-13 06:04:10.326792031 +0000 UTC m=+247935.030261672: ☑️ agreed by cfzjywxk.

@zyguan
Copy link
Contributor Author

zyguan commented Aug 13, 2024

/retest

Copy link

tiprow bot commented Aug 13, 2024

@zyguan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zyguan
Copy link
Contributor Author

zyguan commented Aug 13, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0974%. Comparing base (7e9f853) to head (d27288f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55383        +/-   ##
================================================
+ Coverage   72.9117%   74.0974%   +1.1857%     
================================================
  Files          1576       1576                
  Lines        440552     440590        +38     
================================================
+ Hits         321214     326466      +5252     
+ Misses        99582      94156      -5426     
- Partials      19756      19968       +212     
Flag Coverage Δ
integration 46.8994% <ø> (?)
unit 71.8385% <ø> (-0.1272%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2257% <ø> (+0.3770%) ⬆️

@zyguan
Copy link
Contributor Author

zyguan commented Aug 13, 2024

/merge

Copy link

ti-chi-bot bot commented Aug 13, 2024

@zyguan: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zyguan
Copy link
Contributor Author

zyguan commented Aug 13, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,ekexium,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f9e9b14 into pingcap:master Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the batch efficiency of kv client
3 participants