variable: mark analyze-partition-concurrency-quota as deprecated #55409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
hawkingrei
approved these changes
Aug 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55409 +/- ##
================================================
+ Coverage 72.9180% 76.3835% +3.4655%
================================================
Files 1576 1580 +4
Lines 440611 447426 +6815
================================================
+ Hits 321285 341760 +20475
+ Misses 99553 85435 -14118
- Partials 19773 20231 +458
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tested locally:
#!/usr/bin/env -S cargo +nightly -Zscript
---cargo
[dependencies]
clap = { version = "4.2", features = ["derive"] }
sqlx = { version = "0.7", features = ["runtime-tokio-rustls", "mysql"] }
tokio = { version = "1", features = ["full"] }
fake = { version = "2.5", features = ["derive"] }
---
use clap::Parser;
use fake::{Fake, Faker};
use sqlx::mysql::MySqlPoolOptions;
#[derive(Parser, Debug)]
#[clap(version)]
struct Args {
#[clap(short, long, help = "MySQL connection string")]
database_url: String,
}
#[derive(Debug)]
struct TableRow {
id: i64,
partition_key: u32,
column1: String,
column2: i32,
column3: i32,
column4: String,
}
#[tokio::main]
async fn main() -> Result<(), sqlx::Error> {
let args = Args::parse();
let pool = MySqlPoolOptions::new()
.max_connections(5)
.connect(&args.database_url)
.await?;
// Create partitioned table if not exists
sqlx::query(
"CREATE TABLE IF NOT EXISTS t (
id BIGINT NOT NULL,
partition_key INT NOT NULL,
column1 VARCHAR(255) NOT NULL,
column2 INT NOT NULL,
column3 INT NOT NULL,
column4 VARCHAR(255) NOT NULL,
PRIMARY KEY (id, partition_key),
index idx_column1 (column1)
) PARTITION BY RANGE (partition_key) (
PARTITION p0 VALUES LESS THAN (3000),
PARTITION p1 VALUES LESS THAN (6000),
PARTITION p2 VALUES LESS THAN (9000),
PARTITION p3 VALUES LESS THAN (12000),
PARTITION p4 VALUES LESS THAN (15000),
PARTITION p5 VALUES LESS THAN (18000),
PARTITION p6 VALUES LESS THAN (21000),
PARTITION p7 VALUES LESS THAN (24000),
PARTITION p8 VALUES LESS THAN (27000),
PARTITION p9 VALUES LESS THAN (30000),
PARTITION p10 VALUES LESS THAN (33000),
PARTITION p11 VALUES LESS THAN (36000),
PARTITION p12 VALUES LESS THAN (39000),
PARTITION p13 VALUES LESS THAN (42000),
PARTITION p14 VALUES LESS THAN (45000),
PARTITION p15 VALUES LESS THAN (48000),
PARTITION p16 VALUES LESS THAN (51000),
PARTITION p17 VALUES LESS THAN (54000),
PARTITION p18 VALUES LESS THAN (57000),
PARTITION p19 VALUES LESS THAN (60000),
PARTITION p20 VALUES LESS THAN (63000)
)"
)
.execute(&pool)
.await?;
// Insert 3000 rows into each of the 20 partitions
for partition in 1..=20 {
let partition_key = partition * 3000 + 1; // This ensures each partition key is unique
for _ in 0..3000 {
let row = TableRow {
id: Faker.fake::<i64>(), // Generate a unique id
partition_key, // Use the current partition key
column1: Faker.fake::<String>(),
column2: Faker.fake::<i32>(),
column3: Faker.fake::<i32>(),
column4: Faker.fake::<String>(),
};
sqlx::query(
"INSERT INTO t (id, partition_key, column1, column2, column3, column4)
VALUES (?, ?, ?, ?, ?, ?)"
)
.bind(row.id)
.bind(row.partition_key)
.bind(&row.column1)
.bind(row.column2)
.bind(row.column3)
.bind(&row.column4)
.execute(&pool)
.await?;
}
println!("Successfully inserted 3000 rows into partition {} of the 't' table.", partition);
}
Ok(())
}
set global tidb_analyze_partition_concurrency =1;
mysql> select @@tidb_analyze_partition_concurrency;
+--------------------------------------+
| @@tidb_analyze_partition_concurrency |
+--------------------------------------+
| 1 |
+--------------------------------------+
1 row in set (0.00 sec)
mysql> analyze table t;
Query OK, 0 rows affected, 22 warnings (2.87 sec)
|
Rustin170506
commented
Aug 14, 2024
17 tasks
|
/retest |
songrijie
approved these changes
Aug 14, 2024
|
@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
elsa0520
reviewed
Aug 14, 2024
| @@ -457,7 +438,7 @@ func (e *AnalyzeExec) handleResultsErrorWithConcurrency( | |||
| if isAnalyzeWorkerPanic(err) { | |||
| panicCnt++ | |||
| } else { | |||
| logutil.Logger(ctx).Error("analyze failed", zap.Error(err)) | |||
| logutil.BgLogger().Error("receive error when saving analyze results", zap.Error(err)) | |||
There was a problem hiding this comment.
What's the different between the logger and Bglogger ?
There was a problem hiding this comment.
Logger will try to get the current contextual logger and log some common fields from the context.
In this case, I think there is no difference.
logutil.Logger(internalCtx).Info("use multiple sessions to save analyze results", zap.Int("sessionCount", sessionCount))[2024/08/15 15:10:14.671 +08:00] [INFO] [analyze.go:410] ["use multiple sessions to save analyze results"] [sessionCount=2]
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/approve |
lance6716
approved these changes
Aug 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, elsa0520, hawkingrei, lance6716, songrijie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #55043
Problem Summary:
See my article at #55043 (comment)
What changed and how does it work?
AnalyzePartitionConcurrencyvariable.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.