ddl: Global index more restrictions

[mjonss]

What problem does this PR solve?

Issue Number: close #55424

Problem Summary:
GLOBAL IndexOption was allowed on non-partitioned tables, non-unique indexes, as well as on indexes including all partitioning columns.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Defined2014]

LGTM

Another question, what about create table t(a int, unique index idx(a) local)? Thougth it won't cause any problem, it looks weird.

[mjonss]

LGTM

Another question, what about create table t(a int, unique index idx(a) local)? Thougth it won't cause any problem, it looks weird.

@Defined2014 local should just be ignored, I just added it to be compatible with Oracle Syntax, it is just the same as not specifying it. Only global is a difference from the default (local).

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-15 09:37:56.154559744 +0000 UTC m=+433560.858029399: ☑️ agreed by Defined2014.
• 2024-08-15 09:55:01.377617847 +0000 UTC m=+434586.081087489: ☑️ agreed by tangenta.

[codecov]

Codecov Report

Attention: Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.5093%. Comparing base (c74a233) to head (d357a2e).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55440        +/-   ##
================================================
+ Coverage   74.9176%   75.5093%   +0.5917%     
================================================
  Files          1576       1576                
  Lines        365707     442161     +76454     
================================================
+ Hits         273979     333873     +59894     
- Misses        71965      87615     +15650     
- Partials      19763      20673       +910     

Flag	Coverage Δ
integration	50.5943% <84.6153%> (?)
unit	71.8597% <32.6923%> (-2.0484%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2327%)	⬇️
parser	∅ <ø> (∅)
br	63.0249% <ø> (+15.2065%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,tangenta]
• pkg/ddl/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.3: #55451.