Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: fix the issue that TTL job may hang some time when shrink the delete worker count (#55572) #55612

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55572

What problem does this PR solve?

Issue Number: close #55561

What changed and how does it work?

  • fix some missed count for ErrorRows
  • if a scan task is finished, it will wait for all rows to be processed. If it is not finished in a certain time, the task will go one to mark itself as finished.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 23, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 23, 2024
Copy link

ti-chi-bot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 23, 2024
Copy link

ti-chi-bot bot commented Aug 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-23 08:20:20.553061529 +0000 UTC m=+512815.687511642: ☑️ agreed by YangKeao.
  • 2024-08-23 08:34:56.099210193 +0000 UTC m=+513691.233660316: ☑️ agreed by lcwangchao.

@lcwangchao lcwangchao force-pushed the cherry-pick-55572-to-release-7.1 branch from e562cbb to 38ca5e5 Compare August 23, 2024 08:50
@lcwangchao lcwangchao force-pushed the cherry-pick-55572-to-release-7.1 branch from 38ca5e5 to 82bf74f Compare August 23, 2024 10:01
@ti-chi-bot ti-chi-bot bot merged commit 4ac668d into pingcap:release-7.1 Aug 23, 2024
7 checks passed
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@1b46251). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #55612   +/-   ##
================================================
  Coverage               ?   73.4731%           
================================================
  Files                  ?       1211           
  Lines                  ?     380415           
  Branches               ?          0           
================================================
  Hits                   ?     279503           
  Misses                 ?      83073           
  Partials               ?      17839           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants