-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: introduce hashEqual interface for datum. #55727
Conversation
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55727 +/- ##
================================================
+ Coverage 72.8618% 74.6436% +1.7818%
================================================
Files 1582 1582
Lines 442708 443983 +1275
================================================
+ Hits 322565 331405 +8840
+ Misses 100322 92268 -8054
- Partials 19821 20310 +489
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -1586,6 +1587,20 @@ func ConvertByCollationStr(str string, tp *types.FieldType) string { | |||
return string(hack.String(collator.Key(str))) | |||
} | |||
|
|||
// Hash64 is for datum hash64 calculation. | |||
func Hash64(h base.Hasher, d *types.Datum) { | |||
// let h.cache to receive datum hash value, which is potentially expendable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passing hasher into every encoding logic of datum field means we need to mutate many codec functions, which is dirty.
here we just choose to let hasher ingest datum.HashCode() bytes to make it. See the Line 1606
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@AilinKid: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.