Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add upper bound of retry for sync load #55742

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 29, 2024

What problem does this PR solve?

Issue Number: close #52657

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2024
AilinKid
AilinKid previously approved these changes Aug 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 29, 2024
@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 29, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-29 06:00:16.936378549 +0000 UTC m=+1022812.070828670: ☑️ agreed by AilinKid.
  • 2024-08-29 06:19:14.554600493 +0000 UTC m=+1023949.689050614: ☑️ agreed by winoros.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1-20240828-v7.1.5@8369cf5). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.1-20240828-v7.1.5     #55742   +/-   ##
================================================================
  Coverage                               ?   73.4355%           
================================================================
  Files                                  ?       1211           
  Lines                                  ?     380117           
  Branches                               ?          0           
================================================================
  Hits                                   ?     279141           
  Misses                                 ?      83155           
  Partials                               ?      17821           

@ti-chi-bot ti-chi-bot bot merged commit e011cdd into pingcap:release-7.1-20240828-v7.1.5 Aug 29, 2024
9 checks passed
@hawkingrei hawkingrei deleted the upper_try branch August 29, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants