Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Check sqlkiller status during split region process #56155

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Sep 19, 2024

What problem does this PR solve?

Issue Number: close #55957

Problem Summary:
In 8.1 and earlier versions, during building cop tasks, tidb needs to split key ranges. Tidb may use rpc to connect pd to get latest region info one by one, and this will cost too much time if tidb needs to load many regions' info. Even worse, tidb won't check the sqlkiller signal during this process, so the query won't be killed until the spliting key ranges work is done.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that query won't be killed during building coprocessor tasks process.

yibin added 3 commits September 19, 2024 10:21
Signed-off-by: yibin <huyibin@pingcap.cn>
Signed-off-by: yibin <huyibin@pingcap.cn>
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
Copy link

tiprow bot commented Sep 19, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2024
yibin added 3 commits September 19, 2024 14:39
Signed-off-by: yibin <huyibin@pingcap.cn>
Signed-off-by: yibin <huyibin@pingcap.cn>
Signed-off-by: yibin <huyibin@pingcap.cn>
@yibin87
Copy link
Contributor Author

yibin87 commented Sep 19, 2024

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker September 19, 2024 07:11
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@e0bef39). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #56155   +/-   ##
================================================
  Coverage               ?   71.1774%           
================================================
  Files                  ?       1466           
  Lines                  ?     423102           
  Branches               ?          0           
================================================
  Hits                   ?     301153           
  Misses                 ?     101440           
  Partials               ?      20509           
Flag Coverage Δ
unit 71.1774% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3149% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 19, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Sep 19, 2024

/cc @wshwsh12

@ti-chi-bot ti-chi-bot bot requested a review from wshwsh12 September 19, 2024 08:02
@yibin87
Copy link
Contributor Author

yibin87 commented Sep 19, 2024

/cc @xzhangxian1008

@ti-chi-bot ti-chi-bot bot requested a review from xzhangxian1008 September 19, 2024 08:14
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2024
Copy link

ti-chi-bot bot commented Sep 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-19 07:22:46.235172353 +0000 UTC m=+1118635.975596291: ☑️ agreed by windtalker.
  • 2024-09-19 08:32:23.222191475 +0000 UTC m=+1122812.962615414: ☑️ agreed by xzhangxian1008.

@ti-chi-bot ti-chi-bot bot merged commit af46a3f into pingcap:release-8.1 Sep 19, 2024
18 checks passed
@yibin87
Copy link
Contributor Author

yibin87 commented Sep 19, 2024

/cherrypick release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@yibin87: new pull request created to branch release-7.5: #56159.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants