ddl: Also check column types in ALTER TABLE t PARTITION BY ...

[mjonss]

What problem does this PR solve?

Issue Number: close #56094

Problem Summary:
There were no checks for partitioning expression type if ALTER TABLE t PARTITION BY ..., like it was for CREATE TABLE t ... PARTITION BY ...

What changed and how does it work?

Added check.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.8332%. Comparing base (2838cd6) to head (1895e61).
Report is 50 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56197        +/-   ##
================================================
+ Coverage   73.3843%   76.8332%   +3.4488%     
================================================
  Files          1605       1627        +22     
  Lines        445291     460150     +14859     
================================================
+ Hits         326774     353548     +26774     
+ Misses        98464      85443     -13021     
- Partials      20053      21159      +1106     

Flag	Coverage Δ
integration	52.9200% <94.4444%> (?)
unit	73.3631% <86.1111%> (+0.8491%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	63.1438% <ø> (+17.1128%)	⬆️

[mjonss]

/retest

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[mjonss]

/retest

[Defined2014]

Others LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,Defined2014]
• pkg/ddl/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-24 08:51:01.070918473 +0000 UTC m=+1555930.811342412: ☑️ agreed by Defined2014.
• 2024-09-25 07:04:41.908568959 +0000 UTC m=+1635951.648992883: ☑️ agreed by D3Hunter.

[mjonss]

/retest

[mjonss]

/retest

[mjonss]

/retest

[Frank945946]

@mjonss Please cherry-pick it to LTS v6.5, v7.1, v7.5, and v8.1.