-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: increase tablescan cost for high risk scenarios | tidb-test=pr/2399 #56203
Conversation
Hi @terry1purcell. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/check-issue-triage-complete |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56203 +/- ##
================================================
+ Coverage 73.3954% 75.3432% +1.9477%
================================================
Files 1624 1624
Lines 447375 447484 +109
================================================
+ Hits 328353 337149 +8796
+ Misses 98883 89806 -9077
- Partials 20139 20529 +390
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/retest |
What problem does this PR solve?
Issue Number: close #56012
Problem Summary:
What changed and how does it work?
Add a cost penalty to table scan if we encounter a scenario where a table scan may be risky or we should be preferencing away from table scan.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.