-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix CTE hang or wrong result when multiple Apply is used (#55553) #56265
Merged
ti-chi-bot
merged 4 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-55553-to-release-6.1
Nov 6, 2024
Merged
planner: fix CTE hang or wrong result when multiple Apply is used (#55553) #56265
ti-chi-bot
merged 4 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-55553-to-release-6.1
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
sig/planner
SIG: Planner
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
labels
Sep 24, 2024
13 tasks
Signed-off-by: guo-shaoge <shaoge1994@163.com>
AilinKid
approved these changes
Sep 24, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Sep 24, 2024
XuHuaiyu
approved these changes
Sep 25, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Sep 25, 2024
ti-chi-bot
bot
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Sep 29, 2024
/retest |
…k-55553-to-release-6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
sig/planner
SIG: Planner
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #55553
What problem does this PR solve?
Issue Number: close #55551
Problem Summary:
ExtractOuterApplyCorrelatedCols
is used to find all correlated columns which is inside CTE definition and its corresponding Apply is outside of CTE definition. Check the following diagram,ExtractOuterApplyCorrelatedCols
should NOT returncor_col_3
, becausecor_col_3
's corresponding Apply isApply_3
, which is inside CTE definition.Why need
ExtractOuterApplyCorrelatedCols
: For those CTE whose result ofExtractOuterApplyCorrelatedCols(CTE_definition)
is not empty, we need to re-compute the definition of CTE.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.