Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix unique key get wrong row count when to query the NULL value | tidb-test=2eb0d03843bfec7539602dada4f96ea2ee982c0e #56369

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 27, 2024

…(#56117)

What problem does this PR solve?

Issue Number: close #56116

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
winoros
winoros previously approved these changes Sep 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 27, 2024
qw4990
qw4990 previously approved these changes Sep 27, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 07:40:09.144617771 +0000 UTC m=+1810878.885041704: ☑️ agreed by winoros.
  • 2024-09-27 07:40:55.775333609 +0000 UTC m=+1810925.515757548: ☑️ agreed by qw4990.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.3-20240927-v8.3.0@1a0c3ac). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.3-20240927-v8.3.0     #56369   +/-   ##
================================================================
  Coverage                               ?   74.8206%           
================================================================
  Files                                  ?       1576           
  Lines                                  ?     440678           
  Branches                               ?          0           
================================================================
  Hits                                   ?     329718           
  Misses                                 ?      90786           
  Partials                               ?      20174           
Flag Coverage Δ
integration 49.1758% <75.0000%> (?)
unit 71.9039% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5262% <0.0000%> (?)

@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value planner: fix unique key get wrong row count when to query the NULL value | mysql-test=0bdee035b4f7c06045fac438178ac6623c7140c2 Sep 27, 2024
@hawkingrei
Copy link
Member Author

/retest

@purelind purelind changed the title planner: fix unique key get wrong row count when to query the NULL value | mysql-test=0bdee035b4f7c06045fac438178ac6623c7140c2 planner: fix unique key get wrong row count when to query the NULL value | tidb-test=0bdee035b4f7c06045fac438178ac6623c7140c2 Sep 27, 2024
@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value | tidb-test=0bdee035b4f7c06045fac438178ac6623c7140c2 planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2403 Sep 27, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@purelind purelind changed the title planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2403 planner: fix unique key get wrong row count when to query the NULL value | tidb-test=2eb0d03843bfec7539602dada4f96ea2ee982c0e Sep 27, 2024
@purelind
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Sep 27, 2024

@purelind: No presubmit jobs available for pingcap/tidb@release-8.3-20240927-v8.3.0

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei dismissed stale reviews from qw4990 and winoros via a655831 September 27, 2024 08:51
@ti-chi-bot ti-chi-bot bot removed the approved label Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4c7ce1f into pingcap:release-8.3-20240927-v8.3.0 Sep 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants