Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix the fail of triggering topn fallback action (#56187) #56370

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56187

What problem does this PR solve?

Issue Number: close #56185

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the issue that fails to trigger the fallback action of topn executor

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.3-20240927-v8.3.0 labels Sep 27, 2024
@wshwsh12 wshwsh12 assigned xzhangxian1008 and unassigned wshwsh12 Sep 27, 2024
wshwsh12
wshwsh12 previously approved these changes Sep 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.3-20240927-v8.3.0@1a0c3ac). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.3-20240927-v8.3.0     #56370   +/-   ##
================================================================
  Coverage                               ?   74.7802%           
================================================================
  Files                                  ?       1576           
  Lines                                  ?     440646           
  Branches                               ?          0           
================================================================
  Hits                                   ?     329516           
  Misses                                 ?      90881           
  Partials                               ?      20249           
Flag Coverage Δ
integration 49.0967% <71.4285%> (?)
unit 71.8721% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4961% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 07:45:04.91045547 +0000 UTC m=+1811174.650879406: ☑️ agreed by wshwsh12.
  • 2024-09-27 08:02:13.340663262 +0000 UTC m=+1812203.081087197: ☑️ agreed by xzhangxian1008.

@xzhangxian1008
Copy link
Contributor

/retest

Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 44d06ac into pingcap:release-8.3-20240927-v8.3.0 Sep 27, 2024
18 checks passed
@xzhangxian1008 xzhangxian1008 deleted the cherry-pick-56187-to-release-8.3-20240927-v8.3.0 branch September 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.3-20240927-v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants