Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: make HNSW as vector index default type #56429

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56428

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
Copy link

tiprow bot commented Sep 30, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3920%. Comparing base (cd33d79) to head (067f244).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56429        +/-   ##
================================================
+ Coverage   73.3833%   75.3920%   +2.0086%     
================================================
  Files          1623       1624         +1     
  Lines        447927     449254      +1327     
================================================
+ Hits         328704     338702      +9998     
+ Misses        99078      90000      -9078     
- Partials      20145      20552       +407     
Flag Coverage Δ
integration 49.1292% <8.3333%> (?)
unit 72.4598% <100.0000%> (-0.0069%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3022% <ø> (+6.7859%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 10:52:09.50351074 +0000 UTC m=+265684.923723745: ☑️ agreed by Defined2014.
  • 2024-09-30 12:18:38.400525165 +0000 UTC m=+270873.820738176: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Sep 30, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Oct 8, 2024
@zimulala zimulala added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 8, 2024
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, joey-yez, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2024
@zimulala zimulala removed the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit f7f573b into pingcap:master Oct 8, 2024
20 of 21 checks passed
@zimulala zimulala deleted the zimuxia/hnsw branch October 8, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HNSW the default type for the vector index
5 participants