Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: track the memory usage for building range in IndexLookUpExecutor | tidb-test=2eb0d03843bfec7539602dada4f96ea2ee982c0e #56441

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Oct 3, 2024

What problem does this PR solve?

Issue Number: close #56440

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Test the case in issue 56440, the sql can be killed.
tidb> desc analyze  select /*+ inl_hash_join(t1) */ * from t2 t1 join t2 t2 on t1.b=t2.b;
ERROR 8175 (HY000): Your query has been cancelled due to exceeding the allowed memory limit for a single SQL query. Please try narrowing your query scope or increase the tidb_mem_quota_query limit and try again.[conn=1203765254]

See the slow log, the sql track 1GB and killed.

# Mem_max: 1076188604
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2024
Copy link

tiprow bot commented Oct 3, 2024

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.3-20240927-v8.3.0@4c7ce1f). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.3-20240927-v8.3.0     #56441   +/-   ##
================================================================
  Coverage                               ?   74.7888%           
================================================================
  Files                                  ?       1576           
  Lines                                  ?     440674           
  Branches                               ?          0           
================================================================
  Hits                                   ?     329575           
  Misses                                 ?      90867           
  Partials                               ?      20232           
Flag Coverage Δ
integration 49.1472% <100.0000%> (?)
unit 71.8675% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4461% <0.0000%> (?)

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Oct 3, 2024

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2024
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Oct 3, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
XuHuaiyu
XuHuaiyu previously approved these changes Oct 3, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 3, 2024
guo-shaoge
guo-shaoge previously approved these changes Oct 3, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 3, 2024
Copy link

ti-chi-bot bot commented Oct 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-03 08:18:39.694515652 +0000 UTC m=+515675.114728659: ☑️ agreed by XuHuaiyu.
  • 2024-10-03 08:20:58.087776216 +0000 UTC m=+515813.507989225: ☑️ agreed by guo-shaoge.

@wshwsh12 wshwsh12 changed the title executor: track the memory usage for building range in IndexLookUpExecutor executor: track the memory usage for building range in IndexLookUpExecutor | tidb-test=2eb0d03843bfec7539602dada4f96ea2ee982c0e Oct 3, 2024
@wshwsh12 wshwsh12 dismissed stale reviews from guo-shaoge and XuHuaiyu via 55478c0 October 3, 2024 08:36
@ti-chi-bot ti-chi-bot bot removed the approved label Oct 3, 2024
Copy link

ti-chi-bot bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 726da9c into pingcap:release-8.3-20240927-v8.3.0 Oct 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants