Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics,metrics: allow stats health to have finer granularity #56475

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 8, 2024

What problem does this PR solve?

Issue Number: close #56498

Problem Summary:

What changed and how does it work?

Currently, the stats health feature provides a high-level overview of system health metrics. While this is useful for identifying general trends and issues, it lacks the detailed granularity needed for in-depth analysis and troubleshooting. This enhancement aims to improve the granularity of the stats health metrics, allowing for more precise monitoring and diagnostics.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.6208%. Comparing base (ff1b241) to head (4bc7b2e).
Report is 20 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56475        +/-   ##
================================================
+ Coverage   73.3181%   75.6208%   +2.3026%     
================================================
  Files          1625       1648        +23     
  Lines        448639     459249     +10610     
================================================
+ Hits         328934     347288     +18354     
+ Misses        99547      90805      -8742     
- Partials      20158      21156       +998     
Flag Coverage Δ
integration 50.5417% <40.0000%> (?)
unit 72.7456% <26.6666%> (+0.2989%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 53.1330% <ø> (+7.5873%) ⬆️

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 09:53:44.749034476 +0000 UTC m=+953380.169247487: ☑️ agreed by winoros.
  • 2024-10-09 05:42:15.760771501 +0000 UTC m=+1024691.180984505: ☑️ agreed by AilinKid.

@hawkingrei
Copy link
Member Author

/retest

5 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c49fb9f into pingcap:master Oct 9, 2024
24 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #57091.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #57092.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Stats Health with Finer Granularity
4 participants