-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix data inconsistency after load data ... replace into ...
(#56415)
#56508
executor: fix data inconsistency after load data ... replace into ...
(#56415)
#56508
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, fzzf678 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #56508 +/- ##
================================================
Coverage ? 72.0071%
================================================
Files ? 1415
Lines ? 412509
Branches ? 0
================================================
Hits ? 297036
Misses ? 95563
Partials ? 19910
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #56415
What problem does this PR solve?
Issue Number: close #56408
Problem Summary:
What changed and how does it work?
The reason is the bool flag returned by
removeRow
was not rightly handled inhandleDuplicateKey
.If we load a existed row,
removeRow
will return (true, nil),handleDuplicateKey
should also return (true, nil)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.