-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix mysql_insert_id() for "INSERT .. ON DUPLICATE KEY" statement #56514
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56514 +/- ##
=================================================
- Coverage 73.3698% 56.7697% -16.6001%
=================================================
Files 1626 1752 +126
Lines 448852 634850 +185998
=================================================
+ Hits 329322 360403 +31081
- Misses 99364 250330 +150966
- Partials 20166 24117 +3951
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackysp, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #55965
Problem Summary:
What changed and how does it work?
Handle the value correctly for
mysql_insert_id()
when duplicate update happen in the "INSERT .. ON DUPLICATED UPDATE" statement.In the code internally, we use
InsertID
when the value auto increment column is specified explicitly.And use
LastInsertID
when the value of auto increment column is auto generated.The different between
mysql_insert_id()
andLAST_INSERT_ID()
is that the former get its value either from auto generated or explicitly specified, while the later just update the value in the auto generated cases.Check List
Tests
See the steps descriped in the issue
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.