-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: fix play replay dump cannot save the table in the foreign key's reference (#56512) #56564
domain: fix play replay dump cannot save the table in the foreign key's reference (#56512) #56564
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
72e5142
to
db646a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56564 +/- ##
================================================
Coverage ? 73.4756%
================================================
Files ? 1212
Lines ? 380733
Branches ? 0
================================================
Hits ? 279746
Misses ? 83143
Partials ? 17844 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #56512
What problem does this PR solve?
Issue Number: close #56458
Problem Summary:
What changed and how does it work?
Now, we use extractWorker to traverse the SQL to get the table name. then we use those table names to dump the stats. but we forgot to check the table meta, so we cannot dump the table that is referred to those tables in the SQL.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.