infoschema: Move status and variables to P_S

[dveeden]

What problem does this PR solve?

Issue Number: close #9154

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The `GLOBAL_VARIABLES`, `SESSION_VARIABLES`, `GLOBAL_STATUS` and `SESSION_STATUS` are now only available in the `performance_schema` schema.

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8352%. Comparing base (a22b842) to head (704945f).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56569        +/-   ##
================================================
+ Coverage   72.8488%   74.8352%   +1.9863%     
================================================
  Files          1672       1717        +45     
  Lines        462666     470729      +8063     
================================================
+ Hits         337047     352271     +15224     
+ Misses       104821      96350      -8471     
- Partials      20798      22108      +1310     

Flag	Coverage Δ
integration	49.3371% <ø> (?)
unit	72.3582% <ø> (+0.1365%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	60.6756% <ø> (+15.5530%)	⬆️

[dveeden]

/retest

[mjonss]

Are upgrades affected by this? Or is it just all in memory so it just depends on the TiDB node you are connecting to?

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

Are upgrades affected by this? Or is it just all in memory so it just depends on the TiDB node you are connecting to?

As listed in #9154 (comment) most of these tables are empty with the exception of session_variables.

The session_variables table is populated by GetDataFromSessionVariables() so it doesn't store this on disk.

[dveeden]

/retest

[mjonss]

LGTM, with some suggestions

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-14 03:46:34.525202896 +0000 UTC m=+242791.674112725: ☑️ agreed by lance6716.
• 2024-10-29 10:24:56.682304389 +0000 UTC m=+345409.521459934: ☑️ agreed by mjonss.

[GMHDBJD]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [GMHDBJD,lance6716,mjonss]
• pkg/infoschema/OWNERS [GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dveeden]

/retest