Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: have better crypter key error msg #56589

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Oct 11, 2024

What problem does this PR solve?

Issue Number: close #56388

Problem Summary:

What changed and how does it work?

1. checks the error of decoding hex format on crypto key and return a customized error indicating the hex format is not valid
2. added tests to verify that

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 57.5533%. Comparing base (0f6bddd) to head (e4f537d).
Report is 46 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56589         +/-   ##
=================================================
- Coverage   73.3958%   57.5533%   -15.8426%     
=================================================
  Files          1628       1754        +126     
  Lines        449554     638950     +189396     
=================================================
+ Hits         329954     367737      +37783     
- Misses        99344     247039     +147695     
- Partials      20256      24174       +3918     
Flag Coverage Δ
integration 38.6917% <41.6666%> (?)
unit 73.2737% <22.2222%> (+0.7554%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1248% <41.6666%> (+17.5301%) ⬆️

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 16, 2024

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2024
Copy link

ti-chi-bot bot commented Oct 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 02:00:12.541936913 +0000 UTC m=+409209.690846745: ☑️ agreed by YuJuncen.
  • 2024-10-17 12:52:59.028979934 +0000 UTC m=+534776.177889759: ☑️ agreed by BornChanger.

Copy link

tiprow bot commented Oct 17, 2024

@Tristan1900: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow e4f537d link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 65fcaec into pingcap:master Oct 17, 2024
31 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the error message when BR's --crypter.key is invalid
3 participants