planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2415

[elsa0520]

What problem does this PR solve?

Issue Number: close #56603, close #56582

Problem Summary:

What changed and how does it work?

1. If the CTE contain orderby/limit/distinct and CTE is referenced by another CTE recursive part, it cannot be inlined . Related issue Parsing CTE error with "doesn't yet support 'ORDER BY / LIMIT / SELECT DISTINCT in recursive query block" #56603
2. If the CTE inside of view, the consumerCount of CTE cannot be updated because the view skip the preprocessor phase in during optimizer, it also cannot judge the inline or not. So the CTE inside of view will always be not inlined. Related issue The CTE inside of view can't determine whether it can be inlined #56582

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复错误的 inline CTE，如果 CTE 包含 orderby/limit/distinct 子句并且被另外一个 CTE 的 recursive part 所引用。
同时去除对 view 中的 CTE 进行是否默认 inline 的优化。

[tiprow]

Hi @elsa0520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.4312%. Comparing base (10647c9) to head (8ed01e0).
Report is 19 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56609         +/-   ##
=================================================
- Coverage   73.3366%   56.4312%   -16.9054%     
=================================================
  Files          1629       1753        +124     
  Lines        449954     631627     +181673     
=================================================
+ Hits         329981     356435      +26454     
- Misses        99734     251155     +151421     
- Partials      20239      24037       +3798     

Flag	Coverage Δ
integration	36.9076% <96.2963%> (?)
unit	72.5715% <88.8888%> (+0.0966%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.4232% <ø> (+6.8341%)	⬆️

[elsa0520]

/test mysql-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AilinKid]

REST LGTM

[AilinKid]

cte.isInline is the only the variable declared here and used here, we can use a temporary variable rather than a member variable inside cte?

[AilinKid]

which means this function will return a bool back to the caller

[elsa0520]

It is used by buildSequence fuction so I cannot just return a bool to the caller

func (b *PlanBuilder) tryToBuildSequence(ctes []*cteInfo, p base.LogicalPlan) base.LogicalPlan {
	if !b.ctx.GetSessionVars().EnableMPPSharedCTEExecution {
		return p
	}
	for i := len(ctes) - 1; i >= 0; i-- {
		if !ctes[i].nonRecursive {
			return p
		}
		if ctes[i].isInline || ctes[i].cteClass == nil {
			ctes = append(ctes[:i], ctes[i+1:]...)
		}
	}

[elsa0520]

/test mysql-test

[ti-chi-bot]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-br-integration-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test pull-unit-test-ddlv1
• /test unit-test

The following commands are available to trigger optional jobs:

• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-e2e-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

/test unit-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

/test mysql-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

/test mysql-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

/cherry-pick release-6.5-20241009-v6.5.10

[ti-chi-bot]

@elsa0520: new pull request created to branch release-6.5-20241009-v6.5.10: #56666.

In response to this:

/cherry-pick release-6.5-20241009-v6.5.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[elsa0520]

/cherry-pick release-6.5

[ti-chi-bot]

@elsa0520: new pull request created to branch release-6.5: #56670.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #56694.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #56695.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56696.

[elsa0520]

/cherry-pick release-6.5-20241213-v6.5.11

[ti-chi-bot]

@elsa0520: new pull request created to branch release-6.5-20241213-v6.5.11: #58314.

In response to this:

/cherry-pick release-6.5-20241213-v6.5.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

Hi @elsa0520 , thanks for this fix. Please notice that we always use English on Github, please try to avoid Chinese for the release note.