-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statstics: avoid unnecessary try when to sync load #56614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56614 +/- ##
=================================================
- Coverage 73.3331% 56.4366% -16.8965%
=================================================
Files 1629 1778 +149
Lines 449951 636790 +186839
=================================================
+ Hits 329963 359383 +29420
- Misses 99746 252822 +153076
- Partials 20242 24585 +4343
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
52340f8
to
af2b750
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-8.4 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #56472
Problem Summary:
What changed and how does it work?
Check List
Tests
e2e team has verified it by their e2e test cases/
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.