build(deps): bump go.uber.org/mock from 0.4.0 to 0.5.0 #56720

dependabot · 2024-10-18T04:07:43Z

Bumps go.uber.org/mock from 0.4.0 to 0.5.0.

Release notes

Sourced from go.uber.org/mock's releases.

v0.5.0

0.5.0 (15 Oct 2024)

Added

#153[]: Add --write_command_comment flag to specify whether to include Generated by this command comment.

#191[]: Add --build_constraint flag to add //go:build directives to generated mocks

#214[]: Add gob mode to support custom package loading techniques in place of --exec_only

Changed

#181[]: Made mockgen faster by changing flags passed to go list.

#183[]: Made Cond matcher generic.

#204[]: Removed ISGOMOCK() from generated mocks.

#207[]: Deprecated reflect mode and replaced it with the new package mode.

Fixed

#144[]: Fix a deadlock that can happen when mocking an interface that matches fmt.Stringer.

#168[]: Fix an issue where the "generated by" comment was being included in the package comment of generated mocks.

#144: uber-go/mock#144 #153: uber-go/mock#153 #168: uber-go/mock#168 #181: uber-go/mock#181 #183: uber-go/mock#183 #191: uber-go/mock#191 #204: uber-go/mock#204 #207: uber-go/mock#207 #214: uber-go/mock#214

Thanks to @tulzke @JacobOaks @ARR4N @sashamelentyev @sywhang @fasmat @eyasy1217 @ghouscht @tie @Neo2308 @carson-brill @alexandear @sodul @nbgraham for their contributions this release.

Changelog

Sourced from go.uber.org/mock's changelog.

0.5.0 (15 Oct 2024)

Added

#153[]: Add --write_command_comment flag to specify whether to include Generated by this command comment.

#191[]: Add --build_constraint flag to add //go:build directives to generated mocks

#214[]: Add gob mode to support custom package loading techniques in place of --exec_only

Changed

#181[]: Made mockgen faster by changing flags passed to go list.

#183[]: Made Cond matcher generic.

#204[]: Removed ISGOMOCK() from generated mocks.

#207[]: Deprecated reflect mode and replaced it with the new package mode.

Fixed

#144[]: Fix a deadlock that can happen when mocking an interface that matches fmt.Stringer.

#168[]: Fix an issue where the "generated by" comment was being included in the package comment of generated mocks.

#144: uber-go/mock#144 #153: uber-go/mock#153 #168: uber-go/mock#168 #181: uber-go/mock#181 #183: uber-go/mock#183 #191: uber-go/mock#191 #204: uber-go/mock#204 #207: uber-go/mock#207 #214: uber-go/mock#214

Thanks to @tulzke @JacobOaks @ARR4N @sashamelentyev @sywhang @fasmat @eyasy1217 @ghouscht @tie @Neo2308 @carson-brill @alexandear @sodul @nbgraham for their contributions this release.

Commits

a9c44d9 Release v0.5.0 (#213)
d164a16 Add gob mode to support custom package loading techniques in place of `--exec...
d01ed30 deprecated reflect mode has been replaced with package mode (#207)
6d5eb71 Regenerate generated mocks (#206)
8adc9de feat: mockgen flag --build_constraint to add //go:build directives (#191)
c50d83c Support Go 1.22 and Go 1.23 (#203)
33ccc99 Avoid stringer-related deadlocks without adding ISGOMOCK (#204)
60372e3 chore: gofumpt -w . (#202)
70a5e8c Clarify documentation on Finish (#194)
ec32d99 Bump goreleaser/goreleaser-action from 4 to 6 (#182)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Bumps [go.uber.org/mock](https://github.com/uber/mock) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/uber/mock/releases) - [Changelog](https://github.com/uber-go/mock/blob/main/CHANGELOG.md) - [Commits](uber-go/mock@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: go.uber.org/mock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

ti-chi-bot · 2024-10-18T04:07:52Z

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-10-18T04:08:02Z

Hi @dependabot[bot]. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei · 2024-10-21T03:25:35Z

/ok-to-test

hawkingrei · 2024-10-21T03:28:59Z

/hold

@lance6716 May you update the version of your fork mock.

codecov · 2024-10-21T03:38:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6577%. Comparing base (602f980) to head (08b1c61).
Report is 70 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56720        +/-   ##
================================================
+ Coverage   73.3197%   74.6577%   +1.3379%     
================================================
  Files          1630       1675        +45     
  Lines        450236     458751      +8515     
================================================
+ Hits         330112     342493     +12381     
+ Misses        99850      94506      -5344     
- Partials      20274      21752      +1478

Flag	Coverage Δ
integration	`48.0001% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.1409% <ø> (+16.5913%)`	⬆️

Signed-off-by: lance6716 <lance6716@gmail.com>

lance6716 · 2024-10-21T05:24:58Z

/unhold

ti-chi-bot · 2024-10-21T05:25:04Z

[LGTM Timeline notifier]

Timeline:

2024-10-21 03:25:33.284990793 +0000 UTC m=+235133.981781400: ☑️ agreed by hawkingrei.
2024-10-21 05:25:03.459866109 +0000 UTC m=+242304.156656720: ☑️ agreed by lance6716.

lance6716 · 2024-10-21T05:25:10Z

/assign @Leavrth

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

ti-chi-bot · 2024-10-21T05:33:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hawkingrei, lance6716
Once this PR has been reviewed and has the lgtm label, please ask for approval from leavrth, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~OWNERS~~ [hawkingrei,lance6716]
br/OWNERS
~~pkg/ddl/OWNERS~~ [lance6716]
~~pkg/disttask/OWNERS~~ [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiprow · 2024-10-21T05:36:44Z

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	`08b1c61`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lance6716 · 2024-10-21T05:41:49Z

blocked by uber-go/mock#216

lance6716 · 2024-10-21T05:41:58Z

/hold

ti-chi-bot · 2024-10-21T05:44:54Z

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	`08b1c61`	link	true	`/test build`
pull-unit-test-ddlv1	`08b1c61`	link	true	`/test pull-unit-test-ddlv1`
idc-jenkins-ci-tidb/unit-test	`08b1c61`	link	true	`/test unit-test`
idc-jenkins-ci-tidb/check_dev	`08b1c61`	link	true	`/test check-dev`
idc-jenkins-ci-tidb/check_dev_2	`08b1c61`	link	true	`/test check-dev2`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dependabot · 2024-10-30T01:17:47Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 18, 2024

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 18, 2024

ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2024

update

e9dc1a5

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024

hawkingrei approved these changes Oct 21, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2024

hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 21, 2024

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Oct 21, 2024

hawkingrei requested review from Defined2014 and lance6716 October 21, 2024 03:26

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024

update my patch

1dd3509

Signed-off-by: lance6716 <lance6716@gmail.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2024

update mock

c4ff608

Signed-off-by: lance6716 <lance6716@gmail.com>

lance6716 approved these changes Oct 21, 2024

View reviewed changes

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024

ti-chi-bot bot added lgtm and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2024

ti-chi-bot bot assigned Leavrth Oct 21, 2024

update

08b1c61

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024

hawkingrei closed this Oct 30, 2024

hawkingrei deleted the dependabot/go_modules/go.uber.org/mock-0.5.0 branch October 30, 2024 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): bump go.uber.org/mock from 0.4.0 to 0.5.0 #56720

build(deps): bump go.uber.org/mock from 0.4.0 to 0.5.0 #56720

dependabot bot commented on behalf of github Oct 18, 2024 •

edited by hawkingrei

Loading

ti-chi-bot bot commented Oct 18, 2024

tiprow bot commented Oct 18, 2024

hawkingrei commented Oct 21, 2024

hawkingrei commented Oct 21, 2024

codecov bot commented Oct 21, 2024 •

edited

Loading

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

tiprow bot commented Oct 21, 2024

lance6716 commented Oct 21, 2024

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

dependabot bot commented on behalf of github Oct 30, 2024

build(deps): bump go.uber.org/mock from 0.4.0 to 0.5.0 #56720

build(deps): bump go.uber.org/mock from 0.4.0 to 0.5.0 #56720

Conversation

dependabot bot commented on behalf of github Oct 18, 2024 • edited by hawkingrei Loading

v0.5.0

0.5.0 (15 Oct 2024)

Added

Changed

Fixed

0.5.0 (15 Oct 2024)

Added

Changed

Fixed

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Oct 18, 2024

tiprow bot commented Oct 18, 2024

hawkingrei commented Oct 21, 2024

hawkingrei commented Oct 21, 2024

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

[LGTM Timeline notifier]

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

tiprow bot commented Oct 21, 2024

lance6716 commented Oct 21, 2024

lance6716 commented Oct 21, 2024

ti-chi-bot bot commented Oct 21, 2024

dependabot bot commented on behalf of github Oct 30, 2024

dependabot bot commented on behalf of github Oct 18, 2024 •

edited by hawkingrei

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading