Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, table: list partition support prune non point range #56725

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56673

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
Copy link

tiprow bot commented Oct 18, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.7026%. Comparing base (abf7e31) to head (af640f9).
Report is 15 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56725         +/-   ##
=================================================
- Coverage   73.3543%   56.7026%   -16.6517%     
=================================================
  Files          1635       1761        +126     
  Lines        452734     636677     +183943     
=================================================
+ Hits         332100     361013      +28913     
- Misses       100272     251557     +151285     
- Partials      20362      24107       +3745     
Flag Coverage Δ
integration 37.5160% <81.3333%> (?)
unit 72.9036% <80.0000%> (+0.4191%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6954% <ø> (+6.6787%) ⬆️

@Defined2014 Defined2014 force-pushed the fix56673 branch 3 times, most recently from 4b21e30 to 1591a39 Compare October 21, 2024 07:10
@Defined2014 Defined2014 requested a review from mjonss October 21, 2024 07:49
@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 21, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a curious question about the range optimizer as well as how UNSIGNED bigint partitioning column is handled.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 11:31:32.392502603 +0000 UTC m=+350693.089293213: ☑️ agreed by mjonss.
  • 2024-10-23 10:49:18.528647746 +0000 UTC m=+434559.225438375: ☑️ agreed by winoros.

Copy link

ti-chi-bot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List partition can't prune access partition with greater or less condition
4 participants