Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, stats: overflow estimation may lead to wrong join reorder #56752

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Oct 21, 2024

What problem does this PR solve?

Issue Number: close #56704

Problem Summary:

What changed and how does it work?

When the width of the histogram is tooooo large, it's possible that right bound - left bound exceeds MaxFloat64. Then the width becomes inf, and the later calculation is likely to create NaN.

Join reorder uses MaxFloat64 to do the cost comparison, which leads to the wrong order in the above extreme case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the case that the cost estimation may get INF/NaN in some extreme situations. And fix the wrong join reorder caused by this issue.
修复当代价估算在某些极端情况下估算出 INF/NaN 非法值的问题,以及该问题发生时 join reorder 可能结果出错的问题。

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.3836%. Comparing base (dfd6cf2) to head (d0232c1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56752         +/-   ##
=================================================
- Coverage   73.3217%   56.3836%   -16.9382%     
=================================================
  Files          1631       1784        +153     
  Lines        451083     641229     +190146     
=================================================
+ Hits         330742     361548      +30806     
- Misses       100025     254985     +154960     
- Partials      20316      24696       +4380     
Flag Coverage Δ
integration 37.9788% <70.5882%> (?)
unit 72.4424% <47.0588%> (-0.0028%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6981% <ø> (+6.6655%) ⬆️

@winoros winoros added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Oct 21, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-21 16:00:43.766823618 +0000 UTC m=+280444.463614246: ☑️ agreed by time-and-fate.
  • 2024-10-22 03:07:29.184930158 +0000 UTC m=+320449.881720781: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit eebdcfe into pingcap:master Oct 22, 2024
22 of 24 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56763.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56764.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56765.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56766.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #56767.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@winoros winoros deleted the join-reorder-est-overflow branch October 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overflow during plan cost calculation leads to wrong join reorder
5 participants