Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/stream: added --delete-compactions to log truncate #56761

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56758

Problem Summary:
br log truncate should be able to delete outdated compactions and compacted logs.

What changed and how does it work?

We may finish this by allowing truncate finish by executing all migrations.

Check List

Tests

  • Unit test (TBD)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
Copy link

tiprow bot commented Oct 22, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 30.58824% with 59 lines in your changes missing coverage. Please review.

Project coverage is 75.1635%. Comparing base (924784a) to head (cdc205c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56761        +/-   ##
================================================
+ Coverage   72.8642%   75.1635%   +2.2993%     
================================================
  Files          1677       1722        +45     
  Lines        464210     475036     +10826     
================================================
+ Hits         338243     357054     +18811     
+ Misses       105090      95933      -9157     
- Partials      20877      22049      +1172     
Flag Coverage Δ
integration 49.5536% <17.6470%> (?)
unit 72.6689% <23.5294%> (+0.4088%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.3914% <30.5882%> (+15.7058%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Copy link

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 09:56:28.935385679 +0000 UTC m=+716776.555040195: ☑️ agreed by 3pointer.
  • 2024-11-28 10:02:50.600401843 +0000 UTC m=+717158.220056344: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 65e233e into pingcap:master Nov 28, 2024
33 of 35 checks passed
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Jan 6, 2025
close pingcap#56758

Signed-off-by: hillium <yu745514916@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow br log truncate to delete outdated compactions
3 participants