-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/stream: added --delete-compactions
to log truncate
#56761
Conversation
Signed-off-by: hillium <yu745514916@live.com>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56761 +/- ##
================================================
+ Coverage 72.8642% 75.1635% +2.2993%
================================================
Files 1677 1722 +45
Lines 464210 475036 +10826
================================================
+ Hits 338243 357054 +18811
+ Misses 105090 95933 -9157
- Partials 20877 22049 +1172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close pingcap#56758 Signed-off-by: hillium <yu745514916@live.com>
What problem does this PR solve?
Issue Number: close #56758
Problem Summary:
br log truncate
should be able to delete outdated compactions and compacted logs.What changed and how does it work?
We may finish this by allowing truncate finish by executing all migrations.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.