-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix nulleq condition to calcalate index range (#56769) #56785
planner: fix nulleq condition to calcalate index range (#56769) #56785
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.4 #56785 +/- ##
================================================
Coverage ? 56.2339%
================================================
Files ? 1751
Lines ? 628078
Branches ? 0
================================================
Hits ? 353193
Misses ? 250994
Partials ? 23891
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #56769
What problem does this PR solve?
Issue Number: close #56745
Problem Summary:
What changed and how does it work?
treat col<=>null as range scan instead of point get to avoid incorrect results. so we find it in the
getPotentialEqOrInColOffset
and should return-1
. But this condition is wrong.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.