Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/integrationtest2: go on fixing the tests #56859

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Oct 28, 2024

What problem does this PR solve?

Issue Number: ref #56556

Problem Summary:

What changed and how does it work?

Fix missing test result

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • NA

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.5887%. Comparing base (ed9a909) to head (aa154b6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56859         +/-   ##
=================================================
- Coverage   73.2825%   56.5887%   -16.6938%     
=================================================
  Files          1636       1761        +125     
  Lines        453340     636579     +183239     
=================================================
+ Hits         332219     360232      +28013     
- Misses       100768     252233     +151465     
- Partials      20353      24114       +3761     
Flag Coverage Δ
integration 37.0103% <ø> (?)
unit 72.5516% <ø> (+0.0661%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5607% <ø> (+6.5695%) ⬆️

@ti-chi-bot ti-chi-bot bot added the approved label Oct 28, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 05:45:31.94331721 +0000 UTC m=+242244.782472754: ☑️ agreed by hawkingrei.
  • 2024-10-28 05:49:53.602617422 +0000 UTC m=+242506.441772968: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit c550aae into pingcap:master Oct 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants