-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: use history iterator to scan ddl jobs (#54100) #56896
backup: use history iterator to scan ddl jobs (#54100) #56896
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@3pointer: No presubmit jobs available for pingcap/tidb@release-7.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56896 +/- ##
================================================
Coverage ? 73.4915%
================================================
Files ? 1212
Lines ? 381346
Branches ? 0
================================================
Hits ? 280257
Misses ? 83194
Partials ? 17895 |
This is an automated cherry-pick of #54100
What problem does this PR solve?
Issue Number: close #54139
Problem Summary:
sometimes cluster might have too many ddl jobs. backup should skip unnecessary scan of ddl jobs during the backup incremental ddls.
What changed and how does it work?
Use
GetLastHistoryDDLJobsIterator
instead ofGetAllDDLJobs
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.