-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: mitigate the issue that multiple owner might exist during force to be owner #56963
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56963 +/- ##
=================================================
- Coverage 73.2789% 57.4608% -15.8182%
=================================================
Files 1636 1804 +168
Lines 453658 648330 +194672
=================================================
+ Hits 332436 372536 +40100
- Misses 100846 250408 +149562
- Partials 20376 25386 +5010
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -125,6 +125,8 @@ var ( | |||
domains: map[string]*domain.Domain{}, | |||
} | |||
// store.UUID()-> IfBootstrapped | |||
// TODO this memory flag is meaningless, a store is always bootstrapped once, | |||
// we can always get the version from the store, remove it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we ensure this "TODO" can be tracked and done "later"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have plans to refactor domain and bootstrap part to make it easier to test and maintain quality for further DDL/upgrade evolvement, i will add all TODOs as subtasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, Leavrth, wjhuang2016, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56924, #56713
Problem Summary:
What changed and how does it work?
force owner, see #57185
older versions which don't have the fix of #54689, when upgrade and forcing newer version node to be owner, multiple owner might exist at the same time, this pr tries to mitigate the issue, see code comments for more detail
also mitigate #57003 by sleep after force to be owner
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.