*: Reorg partition fix delete ranges and handling non-clustered tables with concurrent DML

[mjonss]

What problem does this PR solve?

Issue Number: close #56822 ref #45133 close #57510

based on #56974.

Problem Summary:
First the DeleteRange did not include the old replaced Global Indexes,
Then I found an issue with non-clustered tables and reorganize partition,
where double written records during StateWriteOnly/StateWriteReorganization would get Duplicate key errors, due to they would generate new _tidb_rowid in the new partition, making it impossible to detect if an index entry came from Backfilling or if it is new, when recreating the indexes.

What changed and how does it work?

Fixed the DeleteRange, by adding a list of TableID+IndexID ranges that should also be cleaned by DeleteRanges.

Instead of first copy all records and then recreate the indexes, I now use AddRecord table interface, and created both the table record as well as all the index entries for that row. Note that AddRecord will also generate a new _tidb_rowid, so that part of the reorg code is removed as well.

Drawbacks are:

• I'm not sure if we can workaround an index lookup for each unique index entry needed to be written (i.e. if we can batch them instead of do one lookup at a time, or rely on optimistic commit).
• Big change and little time to test it further, including performance difference (correctness is more important though).

Benefits are:

• Simpler code, just check if the record was written with the original handle (_tidb_rowid) and skip if so, otherwise use AddRecord.
• Skipping reading the partitions twice, once for the 'table' records and once for generating the indexes.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix for REORGANIZE PARTITION to remove replaced Global Indexes and handle non-clustered tables unique indexes.

[tangenta]

I think modify expectedDeleteRangeCnt is better.

Agree. This is more like a test, it is better to change the test itself instead of the assertion.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,tangenta]
• pkg/ddl/OWNERS [tangenta]
• pkg/meta/OWNERS [tangenta]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-28 01:45:18.548962945 +0000 UTC m=+687306.168617461: ☑️ agreed by Defined2014.
• 2024-11-28 12:07:08.8963275 +0000 UTC m=+724616.515982021: ☑️ agreed by tangenta.

[mjonss]

/retest

[mjonss]

/retest

[mjonss]

/retest

[mjonss]

/retest

[mjonss]

/retest

[tiprow]

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	7556105	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57812.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #58124.