owner: fix data race on ownerManager.campaignCancel (#56362) #57133
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #56362
What problem does this PR solve?
Issue Number: close #56053
Problem Summary:
m.campaignCancel
is currently set incampaignLoop
goroutine, which might happen after callingcampaignCancel()
that accessm.campaignCancel
, even though it is called afterCampaignOwner()
.What changed and how does it work?
Set
m.campaignCancel
inCampaignOwner()
rather than incampaignLoop
goroutine, to ensure acampaignCancel()
called afterCampaignOwner()
can always accessm.campaignCancel
instead of nil.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.