Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix unexpected duplicate entry error when adding unique index (#56162) #57225

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56162

What problem does this PR solve?

Issue Number: close #56161

Problem Summary: when merge-temp-index workers check duplicate index keys, they use BatchGet() to get index KV from the origin index and record them as a map. However, this map is not updated while handling temp index records, there may be a false-positive detection.

For example, we have {key_1 -> handle_1, key_2 -> handle_2}. If there is a temp index record like key_1 -> handle_3, then there is a duplicate key.

In this issue, we have two temp index records:

key_1 -> handle_1(deleted)
key_1 -> handle_2

The first record passes the check because a delete operation cannot cause a duplicate key. The second record fails the check because handle_2 != handle_1, even if handle_1 is deleted in the previous operation.

What changed and how does it work?

Maintain the map while handling, and remove the delete keys if necessary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 8, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@5e6bbb5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #57225   +/-   ##
================================================
  Coverage               ?   73.4804%           
================================================
  Files                  ?       1212           
  Lines                  ?     381318           
  Branches               ?          0           
================================================
  Hits                   ?     280194           
  Misses                 ?      83237           
  Partials               ?      17887           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 05:33:44.285304853 +0000 UTC m=+247986.476173851: ☑️ agreed by D3Hunter.
  • 2024-11-11 07:21:20.01638351 +0000 UTC m=+254442.207252504: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot bot merged commit 84e7152 into pingcap:release-7.1 Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants