-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix unexpected duplicate entry error when adding unique index (#56162) #57225
ddl: fix unexpected duplicate entry error when adding unique index (#56162) #57225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #57225 +/- ##
================================================
Coverage ? 73.4804%
================================================
Files ? 1212
Lines ? 381318
Branches ? 0
================================================
Hits ? 280194
Misses ? 83237
Partials ? 17887 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #56162
What problem does this PR solve?
Issue Number: close #56161
Problem Summary: when merge-temp-index workers check duplicate index keys, they use
BatchGet()
to get index KV from the origin index and record them as a map. However, this map is not updated while handling temp index records, there may be a false-positive detection.For example, we have
{key_1 -> handle_1, key_2 -> handle_2}
. If there is a temp index record likekey_1 -> handle_3
, then there is a duplicate key.In this issue, we have two temp index records:
The first record passes the check because a delete operation cannot cause a duplicate key. The second record fails the check because
handle_2 != handle_1
, even ifhandle_1
is deleted in the previous operation.What changed and how does it work?
Maintain the map while handling, and remove the delete keys if necessary.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.