Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support stream agg on TiKV #5725

Merged
merged 5 commits into from
Mar 1, 2018
Merged

*: support stream agg on TiKV #5725

merged 5 commits into from
Mar 1, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jan 26, 2018

Relate to tikv/tikv#2714

@shenli
Copy link
Member

shenli commented Jan 27, 2018

LGTM

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2018
@zimulala
Copy link
Contributor Author

zimulala commented Feb 2, 2018

Using 3 TiKV, 1 PD, 1 TiDB, the 3 TiKV are on different servers.
The table schema as follows:

Create Table: CREATE TABLE `lineitem` (
  `L_ORDERKEY` int(11) NOT NULL,
  `L_PARTKEY` int(11) NOT NULL,
  `L_SUPPKEY` int(11) NOT NULL,
  `L_LINENUMBER` int(11) NOT NULL,
  `L_QUANTITY` decimal(15,2) NOT NULL,
  `L_EXTENDEDPRICE` decimal(15,2) NOT NULL,
  `L_DISCOUNT` decimal(15,2) NOT NULL,
  `L_TAX` decimal(15,2) NOT NULL,
  `L_RETURNFLAG` char(1) NOT NULL,
  `L_LINESTATUS` char(1) NOT NULL,
  `L_SHIPDATE` date NOT NULL,
  `L_COMMITDATE` date NOT NULL,
  `L_RECEIPTDATE` date NOT NULL,
  `L_SHIPINSTRUCT` char(25) NOT NULL,
  `L_SHIPMODE` char(10) NOT NULL,
  `L_COMMENT` varchar(44) NOT NULL,
  PRIMARY KEY (`L_ORDERKEY`,`L_LINENUMBER`),
  CONSTRAINT `LINEITEM_FK1` FOREIGN KEY (`L_ORDERKEY`) REFERENCES `orders` (`O_ORDERKEY`),
  CONSTRAINT `LINEITEM_FK2` FOREIGN KEY (`L_PARTKEY`,`L_SUPPKEY`) REFERENCES `partsupp` (`PS_PARTKEY`,`PS_SUPPKEY`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin
rows:6001215 && groups:1.5m && current PR rows:6001215 && groups:1.5m && before percentage decrease rows:59986052 && groups:15m && current PR rows:59986052 && groups:15m && before percentage decrease
select count(L_ORDERKEY), sum(L_LINENUMBER) from lineitem group by L_ORDERKEY; 6.43 sec 7.27 sec 11.6% 31.05s 69.76s 55.5%
6.53 sec 7.36 sec 11.3%
--- --- --- --- --- --- ---
select count(L_ORDERKEY) from lineitem group by L_ORDERKEY; 4.12 sec 4.84 sec 14.9% 19.78s 49.03s 59.7%
4.22 sec 4.61 sec 8.5%
--- --- --- --- --- --- ---
select sum(L_ORDERKEY) from lineitem group by L_ORDERKEY; 5.00 sec 5.51 sec 9.3% 26.76s 52.55s
5.15 sec 5.72 sec
--- --- --- --- --- --- ---
select avg(L_LINENUMBER) from lineitem group by L_ORDERKEY; 6.04 sec 6.21 sec 2.8% 32.26s 61.08s 49.1%
6.15 sec 6.39 sec 3.8%
--- --- --- --- --- --- ---
select avg(L_ORDERKEY) from lineitem group by L_ORDERKEY; 5.97 sec 6.03 sec 1.0% 35.20s 60.59s 41.9%
6.20 sec 6.30 sec 1.6%
--- --- --- --- --- --- ---

@shenli
Copy link
Member

shenli commented Feb 23, 2018

Can we merge this now?

@winoros
Copy link
Member

winoros commented Feb 24, 2018

/run-integration-common-test

@winoros
Copy link
Member

winoros commented Feb 27, 2018

/run-integration-common-test tidb-test=pr/453 tidb-private-test=pr/453

@winoros
Copy link
Member

winoros commented Feb 27, 2018

/run-sqllogic-test

@zimulala
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/453 tidb-private-test=pr/453 tikv=pr/2762

@zimulala
Copy link
Contributor Author

PTAL @winoros

@winoros winoros removed the DNM label Mar 1, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit bf5cae2 into pingcap:master Mar 1, 2018
@zimulala zimulala deleted the stream-agg branch March 1, 2018 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants