Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add hash64 and equal for maxOneRow and fix some bugs. #57259

Merged
merged 2 commits into from
Nov 11, 2024
Merged

planner: add hash64 and equal for maxOneRow and fix some bugs. #57259

merged 2 commits into from
Nov 11, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Nov 9, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AilinKid
.
ccf33a2 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels Nov 9, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 9, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid
AilinKid commented Nov 9, 2024
View reviewed changes
pkg/expression/aggregation/descriptor.go
@@ -89,7 +89,7 @@ func (a *AggFuncDesc) Equals(other any) bool {
return false
}
}
return a.baseFuncDesc.Equals(otherAgg.baseFuncDesc)
return a.baseFuncDesc.Equals(&otherAgg.baseFuncDesc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current Equals implementation only receive pointer

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.65854% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.5576%. Comparing base (426ce3e) to head (2c8924e).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57259        +/-   ##
================================================
+ Coverage   72.9810%   73.5576%   +0.5766%     
================================================
  Files          1660       1662         +2     
  Lines        458645     460213      +1568     
================================================
+ Hits         334724     338522      +3798     
+ Misses       103364     101181      -2183     
+ Partials      20557      20510        -47
Flag Coverage Δ
integration 43.4948% <0.0000%> (?)
unit 72.4145% <53.6585%> (+0.0837%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1221% <ø> (+0.0677%) ⬆️

@AilinKid
.
2c8924e 
Signed-off-by: arenatlx <314806019@qq.com>
windtalker
windtalker approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 05:10:03.617918627 +0000 UTC m=+246565.808787617: ☑️ agreed by windtalker.
  • 2024-11-11 05:27:20.708518124 +0000 UTC m=+247602.899387106: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b5cf2c3 into pingcap:master Nov 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @windtalker @hawkingrei @qw4990