Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: use a global owner manager instance for DDL, to avoid owner change (#57179) #57273

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57179

What problem does this PR solve?

Issue Number: ref #57185

Problem Summary:

What changed and how does it work?

  • use a global owner manager instance for DDL, to avoid owner change during bootstrap, we want it stable. or change back to older version node after upgrade, we want the owner stick on the newer version node.
  • fix br owner manager not closed
  • fix br/bindinfo owner manager report 'the client connection is closing' as the campaign loop exit after client close

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

bootstrap with 3 TiDB of this PR, success, and the owner on first Domain start is still the owner after second start.

upgrade from a 3 TiDB cluster of version v8.1.1, success, and after upgrade, the newer version node is still the owner

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 05:24:15.277122488 +0000 UTC m=+247417.467991472: ☑️ agreed by D3Hunter.
  • 2024-11-11 05:25:52.532066476 +0000 UTC m=+247514.722935473: ☑️ agreed by tiancaiamao.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 71.27660% with 54 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@8f8f6d5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57273   +/-   ##
================================================
  Coverage               ?   56.2844%           
================================================
  Files                  ?       1780           
  Lines                  ?     635478           
  Branches               ?          0           
================================================
  Hits                   ?     357675           
  Misses                 ?     253644           
  Partials               ?      24159           
Flag Coverage Δ
integration 37.0495% <66.4864%> (?)
unit 72.4724% <46.8085%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5189% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, tiancaiamao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 11, 2024
@D3Hunter
Copy link
Contributor

manually pick #57198 to pass CI

@ti-chi-bot ti-chi-bot bot merged commit ed9af44 into pingcap:release-8.5 Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants