-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: use a global owner manager instance for DDL, to avoid owner change (#57179) #57273
ddl: use a global owner manager instance for DDL, to avoid owner change (#57179) #57273
Conversation
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57273 +/- ##
================================================
Coverage ? 56.2844%
================================================
Files ? 1780
Lines ? 635478
Branches ? 0
================================================
Hits ? 357675
Misses ? 253644
Partials ? 24159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth, tiancaiamao, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manually pick #57198 to pass CI |
This is an automated cherry-pick of #57179
What problem does this PR solve?
Issue Number: ref #57185
Problem Summary:
What changed and how does it work?
Check List
Tests
bootstrap with 3 TiDB of this PR, success, and the owner on first Domain start is still the owner after second start.
upgrade from a 3 TiDB cluster of version v8.1.1, success, and after upgrade, the newer version node is still the owner
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.