Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log backup: set a proper maxVersion to resolve lock (#57178) #57280

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57178

What problem does this PR solve?

Issue Number: close #57134

Problem Summary:

  1. See issue.

What changed and how does it work?

To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 11, 2024
@3pointer 3pointer force-pushed the cherry-pick-57178-to-release-7.1 branch from 72c4357 to 38c86f4 Compare November 11, 2024 08:58
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 11:12:12.161370996 +0000 UTC m=+268294.352239980: ☑️ agreed by BornChanger.
  • 2024-11-11 11:42:14.130980691 +0000 UTC m=+270096.321849688: ☑️ agreed by 3pointer.

@3pointer
Copy link
Contributor

/test unit-test

Unstable bootstrap test: Testing //session/bootstraptest:bootstraptest_test (shard 11 of 11) failed: Test failed, aborting

Copy link

ti-chi-bot bot commented Nov 11, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-ddl-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.1/ghpr_build
  • pingcap/tidb/release-7.1/ghpr_check
  • pingcap/tidb/release-7.1/ghpr_check2
  • pingcap/tidb/release-7.1/ghpr_mysql_test
  • pingcap/tidb/release-7.1/ghpr_unit_test

In response to this:

/test unit-test

Unstable bootstrap test: Testing //session/bootstraptest:bootstraptest_test (shard 11 of 11) failed: Test failed, aborting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Nov 11, 2024

@3pointer: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Unstable bootstrap test: Testing //session/bootstraptest:bootstraptest_test (shard 11 of 11) failed: Test failed, aborting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Nov 11, 2024

@3pointer: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1@b51e9e7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #57280   +/-   ##
================================================
  Coverage               ?   73.4787%           
================================================
  Files                  ?       1212           
  Lines                  ?     381441           
  Branches               ?          0           
================================================
  Hits                   ?     280278           
  Misses                 ?      83263           
  Partials               ?      17900           

@ti-chi-bot ti-chi-bot bot merged commit 051f12c into pingcap:release-7.1 Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants