infoschema: don't load table info to get auto_increment value #57296

tangenta · 2024-11-11T10:00:22Z

What problem does this PR solve?

Issue Number: close #57295

Problem Summary:

What changed and how does it work?

Add a method TableIsCached() for infoschemaV2.
Don't load table info in getAutoIncrementID(). If we do, the current auto ID must be zero. Let's return zero directly.
Add a simple unit test.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
After this PR, the same query only takes 80ms.
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-11-11T10:00:58Z

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tangenta · 2024-11-11T10:08:03Z

/check-issue-triage-complete

tiancaiamao · 2024-11-11T10:25:59Z

pkg/infoschema/test/infoschemav2test/v2_test.go

+	tk.MustQuery(autoIncQuery).Check(testkit.Rows("0"))
+	tk.MustExec("insert into t values ();")
+	tk.MustQuery(autoIncQuery).Check(testkit.Rows("5"))
+	tk.MustExec("set @@global.tidb_schema_cache_size = 0;")


There is an API you can use to evict table cache directly, although trigger reload can get the same effect.

is := dom.InfoSchema() ok, v2 := infoschema.IsV2(is) require.True(t, ok) v2.EvictTable(model.NewCIStr("test"), model.NewCIStr("t1"))

The schema is not v2 if we don't reload.

codecov · 2024-11-11T10:30:03Z

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 74.7861%. Comparing base (e16613d) to head (bc5e3d1).
Report is 66 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57296        +/-   ##
================================================
+ Coverage   72.8878%   74.7861%   +1.8983%     
================================================
  Files          1667       1715        +48     
  Lines        460775     472808     +12033     
================================================
+ Hits         335849     353595     +17746     
+ Misses       104289      97083      -7206     
- Partials      20637      22130      +1493

Flag	Coverage Δ
integration	`49.1697% <68.2926%> (?)`
unit	`72.3338% <68.2926%> (+0.0581%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7673% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`60.3570% <ø> (+15.3111%)`	⬆️

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

CbcWestwolf · 2024-11-11T12:03:08Z

pkg/executor/infoschema_reader.go

@@ -242,11 +242,29 @@ func getAutoIncrementID(
 	sctx sessionctx.Context,
 	tblInfo *model.TableInfo,
 ) int64 {
+	if raw, ok := is.(*infoschema.SessionExtendedInfoSchema); ok {


Why do we need this type assertion?

Infoschema that we can get from session is wrapped with SessionExtendedInfoSchema:

tidb/pkg/table/temptable/infoschema.go

Line 23 in a5832b4

func AttachLocalTemporaryTableInfoSchema(sctx variable.SessionVarsProvider, is infoschema.InfoSchema) infoschema.InfoSchema {

ti-chi-bot · 2024-11-12T05:33:11Z

[LGTM Timeline notifier]

Timeline:

2024-11-11 10:26:28.702297169 +0000 UTC m=+265550.893166159: ☑️ agreed by tiancaiamao.
2024-11-12 05:33:10.633279437 +0000 UTC m=+334352.824148433: ☑️ agreed by CbcWestwolf.

ti-chi-bot · 2024-11-12T07:25:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, hawkingrei, tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [CbcWestwolf,hawkingrei,tiancaiamao,wjhuang2016]
~~pkg/infoschema/OWNERS~~ [wjhuang2016]
~~pkg/statistics/OWNERS~~ [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

purelind · 2024-11-12T15:17:09Z

/test all

tiprow · 2024-11-12T15:17:33Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-11-13T00:01:13Z

/retest

purelind · 2024-11-13T02:12:41Z

/retest

tiprow · 2024-11-13T02:13:04Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zimulala · 2024-11-13T02:31:03Z

pkg/executor/infoschema_reader.go

@@ -242,11 +242,29 @@ func getAutoIncrementID(
 	sctx sessionctx.Context,
 	tblInfo *model.TableInfo,
 ) int64 {
+	if raw, ok := is.(*infoschema.SessionExtendedInfoSchema); ok {
+		v2, ok := raw.InfoSchema.(interface {
+			TableIsCached(id int64) bool


Could we use IsV2 which seems easier to understand? It seems that the v1 tables are all cached.

ti-chi-bot · 2024-11-19T06:57:00Z

In response to a cherrypick label: new pull request created to branch release-8.5: #57494.

#57494) close #57295

infoschema: don't load table info to get auto_increment value

46cb7bb

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Nov 11, 2024

update bazel

ef06307

tiancaiamao approved these changes Nov 11, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024

CbcWestwolf reviewed Nov 11, 2024

View reviewed changes

optimize GetDataAndIndexLength

fbe0fd2

ti-chi-bot bot added sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024

fix TestInfoSchemaFieldValue

671d89f

CbcWestwolf approved these changes Nov 12, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 12, 2024

hawkingrei approved these changes Nov 12, 2024

View reviewed changes

wjhuang2016 approved these changes Nov 12, 2024

View reviewed changes

ti-chi-bot bot added the approved label Nov 12, 2024

zimulala reviewed Nov 13, 2024

View reviewed changes

address comment

bc5e3d1

ti-chi-bot bot merged commit eea72ec into pingcap:master Nov 13, 2024
23 checks passed

tangenta added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 19, 2024

ti-chi-bot mentioned this pull request Nov 19, 2024

infoschema: don't load table info to get auto_increment value (#57296) #57494

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024

infoschema: don't load table info to get auto_increment value (#57296) (

ed6d669

#57494) close #57295

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infoschema: don't load table info to get auto_increment value #57296

infoschema: don't load table info to get auto_increment value #57296

tangenta commented Nov 11, 2024 •

edited

Loading

tiprow bot commented Nov 11, 2024

tangenta commented Nov 11, 2024

tiancaiamao Nov 11, 2024

tangenta Nov 12, 2024

codecov bot commented Nov 11, 2024 •

edited

Loading

CbcWestwolf Nov 11, 2024

tangenta Nov 12, 2024

ti-chi-bot bot commented Nov 12, 2024

ti-chi-bot bot commented Nov 12, 2024

purelind commented Nov 12, 2024

tiprow bot commented Nov 12, 2024

hawkingrei commented Nov 13, 2024

purelind commented Nov 13, 2024

tiprow bot commented Nov 13, 2024

zimulala Nov 13, 2024

tangenta Nov 13, 2024

ti-chi-bot commented Nov 19, 2024

infoschema: don't load table info to get auto_increment value #57296

infoschema: don't load table info to get auto_increment value #57296

Conversation

tangenta commented Nov 11, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Nov 11, 2024

tangenta commented Nov 11, 2024

tiancaiamao Nov 11, 2024

Choose a reason for hiding this comment

tangenta Nov 12, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 11, 2024 • edited Loading

Codecov Report

CbcWestwolf Nov 11, 2024

Choose a reason for hiding this comment

tangenta Nov 12, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Nov 12, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Nov 12, 2024

purelind commented Nov 12, 2024

tiprow bot commented Nov 12, 2024

hawkingrei commented Nov 13, 2024

purelind commented Nov 13, 2024

tiprow bot commented Nov 13, 2024

zimulala Nov 13, 2024

Choose a reason for hiding this comment

tangenta Nov 13, 2024

Choose a reason for hiding this comment

ti-chi-bot commented Nov 19, 2024

tangenta commented Nov 11, 2024 •

edited

Loading

codecov bot commented Nov 11, 2024 •

edited

Loading