Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/stream: Added Version Check for Loading Migrations. #57541

Merged
merged 6 commits into from
Nov 21, 2024
Merged

br/stream: Added Version Check for Loading Migrations. #57541

merged 6 commits into from
Nov 21, 2024

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #57540

Problem Summary:
See the issue.

What changed and how does it work?

Added two fields creator and version to Migration. And:

  • We will check whehter the Migration we support when unmarshaling a Migration from the wire or the storage.
  • We will put the commit hash and client type to the Migration when creating a new one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@YuJuncen
added basic version check
c66615c 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
upadted kvproto
5d4d106 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
update kvproto
d3f6005 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
make errdoc
81a0f48 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen YuJuncen changed the title Mig version check br/stream: Mig version check Nov 20, 2024
@YuJuncen YuJuncen changed the title br/stream: Mig version check br/stream: Added Version Check for Loading Migrations. Nov 20, 2024
@YuJuncen
make tidy
2d09f84 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.4982%. Comparing base (865b283) to head (3973770).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57541        +/-   ##
================================================
+ Coverage   72.8846%   74.4982%   +1.6136%     
================================================
  Files          1676       1691        +15     
  Lines        463530     465780      +2250     
================================================
+ Hits         337842     346998      +9156     
+ Misses       104859      97254      -7605     
- Partials      20829      21528       +699
Flag Coverage Δ
integration 46.8643% <27.5862%> (?)
unit 72.2564% <89.6551%> (-0.0217%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.9855% <89.6551%> (+15.6229%) ⬆️
---- 🚨 Try these New Features:

@YuJuncen
Copy link
Contributor Author

/retest-required

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 06:22:40.684252114 +0000 UTC m=+12748.303906629: ☑️ agreed by Leavrth.
  • 2024-11-20 06:45:45.155177936 +0000 UTC m=+14132.774832449: ☑️ agreed by BornChanger.

@YuJuncen
Copy link
Contributor Author

/test pull-br-integration-test

@YuJuncen
Copy link
Contributor Author

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor Author

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor Author

/test unit-test
/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test
/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 20, 2024
@YuJuncen
Copy link
Contributor Author

/test unit-test

@YuJuncen
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiprow tiprow
Copy link

tiprow bot commented Nov 20, 2024

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 91c14a4 into pingcap:master Nov 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BR: Add Verision Checking for Migrations
3 participants
@YuJuncen @BornChanger @Leavrth