Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statstics: fix wrong stats health metrics #57555

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 20, 2024

What problem does this PR solve?

Issue Number: close #57176

Problem Summary:

What changed and how does it work?

we use the wrong index of total table count metrics.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Nov 20, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add unit tests to avoid regression in future

Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 08:54:16.652630952 +0000 UTC m=+21844.272285464: ☑️ agreed by AilinKid.
  • 2024-11-20 09:02:47.485570407 +0000 UTC m=+22355.105224918: ☑️ agreed by lance6716.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.6293%. Comparing base (ad5ca42) to head (b5b42cc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57555        +/-   ##
================================================
+ Coverage   72.8329%   73.6293%   +0.7963%     
================================================
  Files          1676       1706        +30     
  Lines        463539     472278      +8739     
================================================
+ Hits         337609     347735     +10126     
+ Misses       105125     103084      -2041     
- Partials      20805      21459       +654     
Flag Coverage Δ
integration 46.0842% <90.0000%> (?)
unit 72.2285% <90.0000%> (+0.0093%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6543% <ø> (-0.1130%) ⬇️
parser ∅ <ø> (∅)
br 45.3657% <ø> (+0.0090%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot merged commit d8c9190 into pingcap:master Nov 20, 2024
25 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #57559.

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@hawkingrei hawkingrei deleted the fix_wrong_health_stats branch November 28, 2024 10:25
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #57830.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The statistics metric cannot correctly display the stats health
4 participants