Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix unlimited log print "meet lease not found error, refresh session" #57564

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #57533

Problem Summary:

What changed and how does it work?

I'm not sure how the error is triggered.
But reading the code, I can see that line 405, if condition terror.ErrorEqual(err, rpctypes.ErrLeaseNotFound) hold, the error is not reset. So this loop will happen again and again, cause the log print.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Don't know how to reproduce but it's easy to fix by reading the code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 20, 2024
@tiancaiamao tiancaiamao requested a review from D3Hunter November 20, 2024 13:06
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
Copy link

tiprow bot commented Nov 20, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao tiancaiamao requested a review from tangenta November 20, 2024 13:07
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 20, 2024
This reverts commit d85334a.
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 13:24:40.666564459 +0000 UTC m=+38068.286218975: ☑️ agreed by D3Hunter.
  • 2024-11-20 13:26:00.928483656 +0000 UTC m=+38148.548138170: ☑️ agreed by wjhuang2016.

Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, joccau, tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.4755%. Comparing base (d8c9190) to head (195fb14).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57564        +/-   ##
================================================
+ Coverage   72.8374%   73.4755%   +0.6380%     
================================================
  Files          1676       1676                
  Lines        463557     463858       +301     
================================================
+ Hits         337643     340822      +3179     
+ Misses       105100     102259      -2841     
+ Partials      20814      20777        -37     
Flag Coverage Δ
integration 43.4923% <0.0000%> (?)
unit 72.2742% <0.0000%> (+0.0456%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (+0.1129%) ⬆️
parser ∅ <ø> (∅)
br 45.4079% <100.0000%> (+0.0512%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot merged commit 2ce67f8 into pingcap:master Nov 20, 2024
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57568.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb refresh log frequently with "meet lease not found error, refresh session"
6 participants