-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: fix unlimited log print "meet lease not found error, refresh session" #57564
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This reverts commit d85334a.
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, joccau, tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57564 +/- ##
================================================
+ Coverage 72.8374% 73.4755% +0.6380%
================================================
Files 1676 1676
Lines 463557 463858 +301
================================================
+ Hits 337643 340822 +3179
+ Misses 105100 102259 -2841
+ Partials 20814 20777 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57533
Problem Summary:
What changed and how does it work?
I'm not sure how the error is triggered.
But reading the code, I can see that line 405, if condition
terror.ErrorEqual(err, rpctypes.ErrLeaseNotFound)
hold, the error is not reset. So this loop will happen again and again, cause the log print.Check List
Tests
Don't know how to reproduce but it's easy to fix by reading the code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.