runaway: only check statements with a non-empty plan digest #57582
Conversation
Signed-off-by: nolouch <nolouch@gmail.com>
ti-chi-bot
bot
added
release-note-none
| @@ -92,6 +92,10 @@ func (rm *Manager) DeriveChecker(resourceGroupName, originalSQL, sqlDigest, plan | |||
| logutil.BgLogger().Warn("cannot setup up runaway checker", zap.Error(err)) | |||
| return nil | |||
| } | |||
| // Only check the normal statement. | |||
| if len(planDigest) == 0 { | |||
nolouch
force-pushed
the
fix-empty-plan-digest
branch
from
82434d2 to
9aceb5c
Compare
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57582 +/- ##
================================================
+ Coverage 72.8115% 73.4067% +0.5951%
================================================
Files 1676 1676
Lines 463414 468825 +5411
================================================
+ Hits 337419 344149 +6730
+ Misses 105180 103802 -1378
- Partials 20815 20874 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
bot
added
the
needs-cherry-pick-release-8.1
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56897
Problem Summary:
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.