-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix flaky test TestConcurrentLock
#57591
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57591 +/- ##
================================================
+ Coverage 72.8590% 74.7237% +1.8646%
================================================
Files 1676 1721 +45
Lines 463653 474401 +10748
================================================
+ Hits 337813 354490 +16677
+ Misses 104979 97710 -7269
- Partials 20861 22201 +1340
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: hillium <yujuncen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
// Here the path targets to a directory and we will only call `Sync` over it. | ||
// Disable the G304 warning which focus on relative path injection like "../../import_stuff". | ||
//nolint: gosec | ||
baseFD, err := os.Open(base) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we close this baseFD in the Close
method?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tristan1900 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: hillium <yujuncen@pingcap.com>
/test unit-test |
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #56523
Problem Summary:
The test case
TestConcurrentLock
isn't stable enough.What changed and how does it work?
Make it more stable by stronger syncing.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.