Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/mgechev/revive from 1.5.0 to 1.5.1 #57621

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2024

Bumps github.com/mgechev/revive from 1.5.0 to 1.5.1.

Release notes

Sourced from github.com/mgechev/revive's releases.

v1.5.1

Changelog

  • cc3ad5f7029305a998c457669d6aa488312eb311 fix #1066 by ignoring what seems legit modification of value receivers
  • 1070fcdffd702e6114b7cbd885d5b044e9281a37 fix(deps): update module golang.org/x/mod to v0.22.0 (#1099)
  • a4d0c434e156cac5a1f434f6172f9c1894aa0071 fix(deps): update module golang.org/x/tools to v0.27.0 (#1102)
  • ce6965265a43cbfffa688a1729cab9fa907b4331 fix: cli tests on Windows; add tests-on-windows workflow
  • 7ee4500e125e2d1b12653b2c8e140fec380919b4 fix: fixes #1103 by fixing the processing of max-public-structs arguments (#1114)
  • c0d4d07ab65e656e02a52615ec99bdb36038db5b fix: nil panic on old go.mod (issue #1100)
  • 74e2417f7d843c5581af24d353cc3e924cc6c6d6 fix: revive hangs on Windows if go.mod is not found
  • 4c958ef739e982aa7108791d7afe04b76e71aa96 refactor: remove redundant defer
  • be95bfa70536af6446f2b077b323923e8ccb1d09 refactor: rename files to follow Go convention
  • 3378f7033b4c26c7fb987a539ddb4bad6e88b5d7 refactor: replace mutex with sync.Once for rule configuration (#1118)
Commits
  • 3378f70 refactor: replace mutex with sync.Once for rule configuration (#1118)
  • 7ee4500 fix: fixes #1103 by fixing the processing of max-public-structs arguments (#1...
  • cc3ad5f fix #1066 by ignoring what seems legit modification of value receivers
  • ce69652 fix: cli tests on Windows; add tests-on-windows workflow
  • 74e2417 fix: revive hangs on Windows if go.mod is not found
  • 34e9d78 docs: fix mylib example (#1121)
  • 0789e36 docs: lowercase arguments for consistency
  • 8c274eb docs: range-val-* rules are irrelevant for Go 1.22+
  • 4c958ef refactor: remove redundant defer
  • be95bfa refactor: rename files to follow Go convention
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Bumps [github.com/mgechev/revive](https://github.com/mgechev/revive) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/mgechev/revive/releases)
- [Changelog](https://github.com/mgechev/revive/blob/master/.goreleaser.yml)
- [Commits](mgechev/revive@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: github.com/mgechev/revive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 22, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 22, 2024
Copy link

ti-chi-bot bot commented Nov 22, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Nov 22, 2024

Hi @dependabot[bot]. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 23, 2024
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5156%. Comparing base (bd20f66) to head (8ddea65).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57621        +/-   ##
================================================
+ Coverage   72.8127%   73.5156%   +0.7028%     
================================================
  Files          1676       1676                
  Lines        463751     464863      +1112     
================================================
+ Hits         337670     341747      +4077     
+ Misses       105205     102368      -2837     
+ Partials      20876      20748       -128     
Flag Coverage Δ
integration 43.6498% <ø> (?)
unit 72.2716% <ø> (+0.0577%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4649% <ø> (+0.0271%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 25, 2024
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 25, 2024
@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-23 02:02:46.833102203 +0000 UTC m=+256354.452756893: ☑️ agreed by hawkingrei.
  • 2024-11-25 03:16:10.456339008 +0000 UTC m=+433558.075993527: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 21b7889 into master Nov 25, 2024
24 checks passed
@ti-chi-bot ti-chi-bot bot deleted the dependabot/go_modules/github.com/mgechev/revive-1.5.1 branch November 25, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants