Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: provide a system view information_schema.tidb_plan_cache to allow users to see info in the cache #57699

Merged
merged 15 commits into from
Nov 27, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 26, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: provide a system view information_schema.tidb_plan_cache to allow users to see info in the cache

What changed and how does it work?

planner: record more meta info in plan cache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Nov 26, 2024
Copy link

tiprow bot commented Nov 26, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 97.47899% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.0754%. Comparing base (b11d034) to head (edcbe83).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57699        +/-   ##
================================================
+ Coverage   72.8126%   75.0754%   +2.2628%     
================================================
  Files          1677       1722        +45     
  Lines        463954     474640     +10686     
================================================
+ Hits         337817     356338     +18521     
+ Misses       105277      96217      -9060     
- Partials      20860      22085      +1225     
Flag Coverage Δ
integration 49.6528% <47.0588%> (?)
unit 72.6245% <97.4789%> (+0.4095%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.7537% <ø> (+16.2515%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 06:32:39.353326173 +0000 UTC m=+531746.972980689: ☑️ agreed by hawkingrei.
  • 2024-11-26 06:37:30.013551931 +0000 UTC m=+532037.633206446: ☑️ agreed by elsa0520.

@ti-chi-bot ti-chi-bot bot removed the approved label Nov 26, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@qw4990 qw4990 changed the title planner: record more meta info in plan cache planner: provide a system view information_schema.tidb_plan_cache to allow users to see info in the cache Nov 26, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Nov 26, 2024

The CI is broken.

@wuhuizuo
Copy link
Contributor

/retest

Copy link

tiprow bot commented Nov 26, 2024

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/retest

Copy link

tiprow bot commented Nov 26, 2024

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 26, 2024
@purelind
Copy link
Contributor

/retest

Copy link

tiprow bot commented Nov 27, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow edcbe83 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 27, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Nov 27, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Nov 27, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 0374ae2 into pingcap:master Nov 27, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants